My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 639: Keyboard Shortcuts don't work 100% in recent WebKit browsers
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2012


Sign in to add a comment
 
Reported by joel.pea...@gmail.com, Jul 27, 2010
Original discussion from the mailing list: http://groups.google.com/group/repo-discuss/browse_thread/thread/2d9e87f4beeb3f8b/fbc18ce13f5ef7cb#fbc18ce13f5ef7cb

Affected Version: 2.1.3

Keyboard shortcuts don't work 100% in Google Chrome (or Safari).  They all seem to work fine in 
Firefox and IE. 
The shortcuts which don't work properly in Google Chrome are (Tested 
in Ubuntu 10.04 and Windows XP): 
<Ctrl> + d : discard draft comment, it adds a bookmark instead. 
<Ctrl> + s : save draft comment, it tries to "Save File" instead. 
c : Create a new inline comment.  It does work, but when the draft 
textarea box appears it has the "c" character in it. 

I have attached a patch that partially gets Google Chrome working for <ctrl> +s and d, but after pressing <ctrl> + s the j and k keyboard shortcuts stop working.  After <ctrl> + d it works ok.

So, not entirely sure what I missed.  Maybe someone else knows why Google Chrome ends up in that state.
0001-Get-Ctrl-s-Ctrl-d-kinda-working-in-Google-Chrome.patch
3.3 KB   View   Download
Aug 19, 2010
#1 sop@google.com
 Issue 431  has been merged into this issue.
Aug 19, 2010
#2 sop@google.com
Fixed by I08732be288f1149073d85bc5e09ab4cfb6547f8f
Status: Fixed
Labels: FixedIn-2.1.4.1
Aug 19, 2010
#3 sop@google.com
(No comment was entered for this change.)
Labels: -FixedIn-2.1.4.1 FixedIn-2.1.5
Mar 27, 2012
#4 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting