My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 620: Possibility to remove trailing whitespaces on server side
4 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


Sign in to add a comment
 
Reported by annu...@gmail.com, Jul 6, 2010
Add a possibility to remove trailing whitespaces on server side
Jul 13, 2010
#1 sop@google.com
The problem with this is we have edit the commit, which
changes the commit SHA-1.  If you have a local branch
that is pointing at the change, it won't be correct after
the server has made the edit.

I guess its no worse than the reviewer doing a cherry-pick
and uploading their own replacement after using rebase with
the --whitespace=fix option.  If we send out a notification
that the whitespace was trimmed, it just saves the reviewer
some steps to clean up an otherwise fine patch before they
submit it to the repository.
Status: Accepted
Sign in to add a comment

Powered by Google Project Hosting