My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 62: Gerrit doesn't work on IE 7
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Wed Feb 04 14:34:04 PST 2009
Source: JIRA GERRIT-62
Affected Version: 2.0.1
Environment: IE version 7.0.5730.13

JavaScript error.  Something about 'Object expected'.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Feb 09 13:31:39 PST 2009

See also this thread on IE 6:

http://groups.google.com/group/repo-discuss/browse_thread/thread/3b4c6ad9e82c4d6b

Something about "an unknown file type back".
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Feb 10 08:27:19 PST 2009

If I had to take a guess, its the gwtjsonrpc callbacks that have IE upset.
Perhaps IE doesn't like the application/json Content-Type response being used
by the JsonServlet when it sends an RPC call result back to the client?

I don't have a Windows system, and Windows support isn't a priority for
Google's engineers (most run Linux).  Those few engineers who might run
Windows prefer Firefox or Chrome over IE anyway.

This bug is going to have to be fixed by someone (not me) who needs IE
support, and has access to a Windows system running IE.
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Tue Feb 24 18:11:32 PST 2009
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Feb 24 18:54:29 PST 2009

Debugged on IE 6.0.2900.5512 (XP SP3).

Bug in gwtjsonrpc:  MSIE doesn't like "delete window[name]".  The RPC library
was doing this when handling cached data.

Bug in gerrit:  MISE doesn't permit innerHTML to be assigned on a tbody
element.  Gerrit does this when building up a table on the fly.
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Tue Feb 24 19:34:19 PST 2009

Partial fixes:

https://review.source.android.com/8990
https://review.source.android.com/8992

With these in place, Gerrit mostly works on IE.
Sep 24, 2009
#6 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Tue Feb 24 19:37:53 PST 2009
Sep 24, 2009
#7 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Tue Feb 24 19:42:10 PST 2009

Fixed in version 2.0.5.
Status: Fixed
Sep 24, 2009
#8 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Wed Feb 25 08:30:57 PST 2009
Blockedon: 84
Sep 24, 2009
#9 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Wed Feb 25 08:52:25 PST 2009

Also tested under MSIE 7.0.5730.13.  Behavior is about the same as MSIE 6.
See GERRIT-84 for outstanding annoyances, but its mostly functional.
Sep 25, 2009
#10 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.5
Oct 25, 2012
#11 sop@google.com
(No comment was entered for this change.)
Status: Released
Blockedon: -gerrit:84
Sign in to add a comment

Powered by Google Project Hosting