My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 593: Support for files that are modified and renamed in the same patch
4 people starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by x...@google.com, Jun 10, 2010
Affected Version:2.1.2.4-70-g2366d78

I have a patch where a file is both modified and considered renamed by git. The comment in the the text editor when doing "git commit" is:

#       modified:   com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/build/ApkBuilder.java
#       renamed:    com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/build/ApkBuilder.java -> com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/build/ApkBuilderHelper.java

And when saving the commit message it shows:
rewrite eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/build/ApkBuilder.java (61%)
rename eclipse/plugins/com.android.ide.eclipse.adt/src/com/android/ide/eclipse/adt/internal/build/{ApkBuilder.java => ApkBuilderHelper.java} (53%)

But when I look at the patch on Gerrit, ApkBuilderHelper.java shows as "created" which means the side by side diff doesn't compare it to ApkBuilder.java.

The patch on Gerrit is visible here: https://review.source.android.com/#change,15221

I see that both gitx and "git diff HEAD~1" show the file as new in the diff, but it would be really useful to have gerrit show the file as renamed.

Sign in to add a comment

Powered by Google Project Hosting