| Issue 589: | Watch Projects Suggestion Box not working | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.1.2.5
What steps will reproduce the problem?
1. Log in as administrator
2. Remove all read access for "All Projects" project
3. Go to Settings tab "Watched Projects"
4. Enter some character in "Project Name" text box
5. No project suggestion appears
What is the expected output?
A list of suggested projects.
Please provide any additional information below.
I have already checked in the code and the problem might be in class
gerrit-httpd/src/main/java/com/google/gerrit/httpd/rpc/SystemInfoServiceImpl.java
on method "suggestProjectNameKey".
It does not check if the current user is the administrator. The block of code is below:
for (final Project p : db.projects().suggestByName(a, b, n)) {
final ProjectState e = projectCache.get(p.getNameKey());
if (e != null && e.controlFor(user).isVisible()) {
r.add(p.getNameKey());
}
}
If you want to, I can submit a solution for this.
Please let me know.
Jun 8, 2010
#1
monica.d...@sonyericsson.com
Jun 16, 2010
Works as designed. An administrator can only "see" a project or its changes if he/she also has READ +1 access to it. However, we give them an exemption from that rule only in the Admin > Projects area, so they can configure access rights for projects. If you want to enable watching a project, you need to make it readable by yourself.
Status:
WontFix
|
|
| ► Sign in to add a comment |