My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 581: Add URL pointing to the Gerrit change in reexamine e-mail notifications
2 people starred this issue and may be notified of changes. Back to list
Status:  Invalid
Owner:  ----
Closed:  Jun 2010


Sign in to add a comment
 
Reported by jjhel...@gmail.com, Jun 2, 2010
Affected Version: 2.1.2.2

Enhancement request.

What steps will reproduce the problem?
1. Upload a change.  You will get an e-mail with a link to the change in 
Gerrit, e.g. http://example.com/r/1876
2. Amend the change and re-upload it.  You will get an e-mail which looks 
something like this:

8<
Hello John Doe,

I'd like you to reexamine change I5522498f.
Change I5522498f (patch set 4) for master in repo-x:
8<

Unfortunately this e-mail doesn't contain a direct URL to the change that 
was amended (e.g., above http://example.com/r/1876).

Having the link would help reviewers get to changes quicker as you could 
just click on the link in the e-mail rather than searching through e-mails 
for the original change or searching for the change in Gerrit by the 
change-id.

Jun 2, 2010
#1 sop@google.com
 Issue 582  has been merged into this issue.
Jun 16, 2010
#2 sop@google.com
This occurs because you didn't set gerrit.canonicalWebUrl in
your gerrit.config.  If that isn't set, pushes over SSH don't
know how to hyperlink back to the change, so they can't
include the URL in the email.  The code just skips over
the link.
Status: Invalid
Sign in to add a comment

Powered by Google Project Hosting