My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 579: Persist diff formating preferences
4 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2012


Sign in to add a comment
 
Project Member Reported by ziv...@gmail.com, May 26, 2010
Diff formatting preferences (Ignore Whitespace, Syntax Coloring, etc...)
are not persisted. If a user prefers anything else but the gerrit defaults
he/she has to adapt preferences each time when the diff view opens.

I propose to persist users diff preferences in a new table
account_diff_prefs. The preferences should be persisted every time when
user clicks the Update button.
May 26, 2010
#1 sop@google.com
(No comment was entered for this change.)
Status: Accepted
Jun 18, 2010
Project Member #2 ziv...@gmail.com
Pushed a first patch set as a basis for further discussion.

The "Show Full File" flag value is derived from the "Default Context" setting
in the Preferences and because of that not persisted in the account_diff_preferences.
I wasn't sure what to do about it.
The number of context lines belongs rather to the PatchScriptSettingsPanel than to
the preferences panel IMO.
Any opinions on that?
Jun 21, 2010
#3 sop@google.com
I'll comment more on the code [1] in a minute.

For "Show Full File" flag, I agree, its default off the
context and therefore shouldn't be a preference.

I think you are also right, now that we have that common
PatchScriptSettingsPanel, the context lines should go in
there rather than on the higher level account.

[1] https://review.source.android.com/15353
Jul 13, 2010
#4 sop@google.com
Fixed in I52cd1dcf702ed04046b236228f994fb9042243d9
Status: Fixed
Labels: FixedIn-2.1.4
Mar 27, 2012
#5 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting