My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 56: uploaded patches marked as approved / verified.
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Brian Swetland <swetland@android.com> on Wed Jan 28 21:19:40 PST 2009
Source: JIRA GERRIT-56
Affected Version: 2.0

Kernel team does not want changes to be automatically marked as approved just
because the submitter happens to be a valid approver.

We have the same issue with verified.

We want verification and approval to require explicit action on the part of
somebody and never to be a side-effect of merely submitting a patch.

Submitting a revised patch should automatically un-approve and un-verify.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu Jan 29 10:25:04 PST 2009

Fixed in version 2.0.1.
Status: Fixed
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu Jan 29 10:25:04 PST 2009

Fixed by http://review.source.android.com/8706
Sep 25, 2009
#3 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.1
Oct 25, 2012
#4 sop@google.com
(No comment was entered for this change.)
Status: Released
Blocking: -gerrit:144
Sign in to add a comment

Powered by Google Project Hosting