| Issue 557: | Allow rejection of changes without Change-Id line. | |
| 8 people starred this issue and may be notified of changes. | Back to list |
We see a lot of people that do silly things, such as having a blank line between a Change-Id line and the Signed-off-by line, or just not having a Change-Id line, and creating a cascade of new commits as they upload new changes. It would be nice to be able to configure Gerrit either in general, or perhaps as a permission, to reject commits that don't have a Change-Id line.
May 6, 2010
#1
nas...@chromium.org
May 6, 2010
(No comment was entered for this change.)
Status:
Accepted
Owner: nas...@codeaurora.org
Jun 16, 2010
Issue 599 has been merged into this issue.
Jun 16, 2010
@nas are you planning on working on this?
Jun 16, 2010
Not in the near future. Please take it up if you are able.
Owner:
---
Aug 13, 2010
Is this a dupe (or related to?) of issue 547?
Aug 13, 2010
Its related to but not a dupe. This bug is about rejecting changes that don't have a Change-Id line. Issue 547 is about rejecting changes that have a line, but where the line isn't a valid line.
Sep 21, 2010
I've noticed that there is a change for review that addresses this issue: https://review.source.android.com/17269
Oct 12, 2010
Fixed by I8bb545d19d4ab04278cd1f185401f4dc3cefbcc4
Status:
Submitted
Labels: FixedIn-2.1.6
Dec 15, 2010
(No comment was entered for this change.)
Status:
Released
Dec 15, 2010
This is definitely an improvement, but, it affects pushes to all branches. I was hoping for it only to affect the refs/for/<branch> space. I wonder if it shouldn't therefor be a permission instead of a repo-wide checkbox? The problem is that I've got repo's based on upstream sources, so I can't update the upstream branches w/o first disabling the checkbox.
Dec 17, 2010
I also agree that this should be restricted refs/for/** - in our case normal users need the check in place, the build machine however needs to push directly to the branch and won't have a change id. I've therefore reaised issue 805 https://code.google.com/p/gerrit/issues/detail?id=805 |
|
| ► Sign in to add a comment |