My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 553: Description parsing adds invalid reviewers
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2012


Sign in to add a comment
 
Reported by di...@google.com, Apr 29, 2010
Affected Version: 2.1.2.2

What steps will reproduce the problem?
Create a change with a description that has a line like "Other-Bug-Id: 
12345"

What is the expected output? What do you see instead?
Nothing special should happen, the description should be displayed (maybe 
with some link if I configure Gerrit to match on that kind of bug id lines). 
Instead it seems to be adding a reviewer to the change that is printed as 
"Anonymous Coward (12345)". There is no trace of this user in the database.

Apr 29, 2010
#1 nas...@chromium.org
I can confirm that I've seen this bug as well. I've had no luck tracking down what is 
causing it (even with good pointers from sop).
May 4, 2010
#2 sop@google.com
This is data dependent, it depends on the footer tag you
use in your commit message.

JGit seems to honor "Google-Bug-Id:" as being equal with
"Signed-off-by:".  They aren't.  But JGit says they are.

Its randomly reproducing sometimes because some strings are
equal to "Signed-off-by" according to JGit, and others aren't.

And lets also not mention the WTF that "Signed-off-by: 42" will
match to account number 42 in the database.  It should have only
matched if there was at least a name or an email address.  :-\
Status: Started
Labels: Component-JGit
May 4, 2010
#3 sop@google.com
Fixed by Ie26974240f26d29fb55cd95dc6b6c72c89903f37
Status: Fixed
Labels: FixedIn-2.1.2.4
Mar 27, 2012
#4 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting