My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 532: gerrit.sh uses "disown" bash-specific builtin so it should be #!/bin/bash not #!/bin/sh
1 person starred this issue and may be notified of changes. Back to list
Status:  CannotReproduce
Owner:  ----
Closed:  Apr 2010


Sign in to add a comment
 
Project Member Reported by jaysoff...@gmail.com, Apr 11, 2010
Affected Version: 2.1.2.2

See summary. This is a problem on Ubuntu/Debian where /bin/sh is /bin/dash by default.


Apr 12, 2010
#1 sop@google.com
Doesn't Ubuntu/Debian have start-stop-daemon available?
So why are you using the fallback code path for when it
is not present?
Status: AwaitingInformation
Apr 12, 2010
Project Member #2 jaysoff...@gmail.com
Interesting. I linked gerrit.sh into /etc/init.d and then just called it directly (/etc/init.d/gerrit.sh start) and it 
apparently did not use start-stop-daemon. Now to go figure out why...
Apr 12, 2010
Project Member #3 jaysoff...@gmail.com
Okay, not sure why it wanted to use the fall-back path, but it's not reproducing. Feel free to close. Sorry for the 
noise.
Apr 12, 2010
#4 sop@google.com
(No comment was entered for this change.)
Status: CannotReproduce
Feb 4, 2011
#5 bgilb...@backtick.net
I also encountered this problem during the initial setup process on Ubuntu 10.04, when running gerrit.sh as the gerrit user.  Running gerrit.sh as an initscript (and thus as root) fixed it.

Fallback or no fallback, however, it is incorrect to ask for #!/bin/sh if you're going to use non-POSIX features.
Sign in to add a comment

Powered by Google Project Hosting