My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 505: Allow reviewer to make code changes
26 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Sep 2014


Sign in to add a comment
 
Reported by alexea...@google.com, Mar 20, 2010
I just talked to Tyler about this feature I've always wanted. He showed me 
Gerrit and it looks like this might be something Gerrit could do.

I'd like the reviewer to be able to make code changes. Maybe there's a 
minor style nitpick, and they could just make the change instead of writing 
instructions for the reviewee to do it. Or, they might make a substantive 
comment about an alternate implementation and want to explain it in 
terms of code rather than writing it out as a narrative.

The changes made by the reviewer should appear as just another patch set, 
with their name next to it in the revision history list.

I blogged a longer version of the reasoning for this here: 
http://jakeherringbone.com/2009/08/what-code-reviews-ought-to-be/
Mar 20, 2010
#1 sop@google.com
We might be able to embed Bespin or something.
Status: Accepted
Mar 23, 2010
#2 nas...@chromium.org
You should also note that reviewers are (generally) allowed to upload a new patch set 
to someone else's change (unlike Rietveld where they'd need to create a new review).
Mar 23, 2010
#3 sop@google.com
Which is one reason why its OK for us to also offer an online
editor directly in the browser.  After the edit is complete the
reviewer has just "uploaded" a new patch set onto the review.

:-)
Jun 16, 2014
#4 mani.cha...@gmail.com
Hi,
It seems that this feature (Allow reviewer to make code changes) is available in gerrit.
Can you please let me know the link to change which was submitted for this feature.
Thanks.
Jun 16, 2014
#5 neufe...@googlemail.com
Imho even the review-screens in 2.9 don't allow you to edit sourcecode-files directly. See: https://gerrit-documentation.storage.googleapis.com/Documentation/2.9/user-review-ui.html
Sep 10, 2014
Project Member #7 David.Os...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.11
Apr 16, 2015
Project Member #9 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting