| Issue 498: | Keyboard navigation from change page into diffs | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Currently keyboard nav allows a user to travel to the over view pages ("My >
Changes"), navigate changes and then select them.
Inside a diff a user can keyboard navigate to the next hunk, next change,
review, etc.
There is a disconnect, after you navigate via the keyboard to the change
page, you cannot navigate the to the files in the changeset and select them
for review.
Don't make me reach for that cursed mouse! ;)
Mar 15, 2010
#1
sop@google.com
Status:
Accepted
Jul 8, 2010
I've looked into this topic and pushed a first implementation for review: https://review.source.android.com/15676
Jul 12, 2010
Fixed in I577f0a2d5b6da20d48b5cf80035c2571ee903ebb
Status:
Fixed
Labels: FixedIn-2.1.4
Jul 14, 2010
This change introduced a NullPointerException when a change is abandoned. I've pushed a fix for review: https://review.source.android.com/15799
Jul 14, 2010
Key navigation does not work properly for an abandoned change. If a change is abandoned e.g. the key commands to jump to previous and next patch set are not registered. I will have a look at this tomorrow.
Owner:
edwin.kempin
Jul 15, 2010
I checked the keyboard navigation once again and found that it gets disabled when the change screen gets updated without reloading the complete screen. This happens for example when a change gets submitted or abandoned. I've pushed a fix for review: https://review.source.android.com/15822
Mar 27, 2012
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |