My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 49: Mine screen loads empty rather than with a login dialog
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Wed Jan 28 09:03:20 PST 2009
Source: JIRA GERRIT-49
Affected Version: 2.0

Visit Gerrit#mine while not signed in, from a new browser window.  The page
loads with all three sections empty.  If you sign in, the page doesn't reload.

Really we should have had #mine check that you aren't signed in and pop the
sign in dialog, and claim "Not Found" if the sign in was canceled/failed.

I suspect the dashboard screen can't tell we were relying on the current user
and issued the RPC anyway, and the server sent back a valid, but empty,
result, so we never tested the user's account cookie.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Thu Jan 29 12:38:55 PST 2009

Fixed by http://review.source.android.com/8715
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu Jan 29 12:38:55 PST 2009

Fixed in version 2.0.1.
Status: Fixed
Sep 25, 2009
#3 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.1
Oct 25, 2012
#4 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting