My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 471: Change rejected for whitespace issues showed up anyway
2 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Feb 2010


Sign in to add a comment
 
Reported by virgilk...@google.com, Feb 26, 2010
Affected Version: today's

What steps will reproduce the problem?
1. Submit a change which fails the draconian new line length requirements

What is the expected output? What do you see instead?
Expect not to see the change in gerrit but in fact it is there.

Please provide any additional information below.
One change where I saw this was 42404.
BTW why the new line length restrictions? Do we really still need to make 
people break their lines manually?
Feb 26, 2010
#1 sop@google.com
Do you really want this to be a hard failure?  I assumed the user
might need to sometimes override the check and upload the
change anyway.

As far as why this check exists, EVERY OTHER git tool out there
assumes commit messages will be about 70 columns wide, and
have about a 65 character subject in the first line.  Gerrit wants
you to confirm to their existing conventions so tools like git log
on a standard 80 column wide terminal still work as expected,
or so gitk can display a change as expected.  Etc.

I'll relax the setting and permit the browser to line wrap when
there is a *RELEASED* version of Git and gitk which does line
wrapping automatically for commit log messages.  Given prior
discussions with developers on the git mailing list this will not
happen.  They do not want to mangle or malform the message
supplied in any way, as often messages contain ASCII art, or
some other styled text that line wrapping could easily destroy.

I think this is about the best we can do:  warn the user that
they are doing something they shouldn't.
Status: WontFix
Feb 26, 2010
Project Member #2 Shane...@gmail.com
I don't suppose you fancy making it possible to disable the warning (either per-user
or per-server)?

All the tools we use seem like they could care less about long lines and happily
display them without a problem (This includes git log), and when I'm writing a commit
log my first instinct on my 24" monitor isn't "oh, I need to wrap this at a quarter
of the width of my monitor"
Feb 26, 2010
#3 virgilk...@google.com
Sorry sop, I misunderstood what happened. I was watching over someone's shoulder as 
they submitted that change and their impression was that it was a hard failure. A 
warning seems like a reasonable behavior but the current text may imply that it's 
necessary to change the commit message and upload again.

I don't want to try to overrule everyone on the mailing list but philosophically I 
think that requiring users to provide non-meaningful hard line breaks is wrong. I 
would rather read long commit messages in today's git log than set up my editor to 
generate hard breaks that make the message unsuitable for any display width other 
than a standard terminal.
Jul 27, 2010
#4 antony.s...@gmail.com
I also agree with virgilk. How about making line wrapping optional?
Jul 27, 2010
#5 sop@google.com
I'm really against it because the only Git tool that
line wraps commit messages automatically is another
fringe product, EGit (the Eclipse Git plugin).  Every
other tool out there that matters requires hard line
wrapping at commit time in order to get a readable
message in those tools.  Adding automatic wrapping in
Gerrit's web UI only helps Gerrit web UI users, and it
puts everyone else at a disadvantage.

*IF* someone sends me a change containing a really well
written implementation of optional line wrapping in the
web UI, and it merges cleanly, I'll seriously consider
including it in a future version of Gerrit.  But I really
don't want this, so I won't even take the time to try and
correct minor issues in the change, or to cherry-pick it
onto current master if it gets out of date.  Usually I'm
willing to help an author clean up their code, because I
want the feature or bug fix they are offering.  Here is a
case where I really don't want it, so its got to be a really
compelling change for me to bring it in.
Jul 27, 2010
#6 antony.s...@gmail.com
Not so, GitX does line wrapping both in it's commit editor and it's log display.
Jul 27, 2010
Project Member #7 bklarson@gmail.com
Yeah, but git-log, gitk, etc will show up with difficult-to-read commit messages.  I'd prefer to see these tools stay usable and encourage developers to line-wrap as appropriate
Sign in to add a comment

Powered by Google Project Hosting