| Issue 450: | Stop using tables for layout | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Affected Version: 2.1.1 Environment: Ubuntu (karmic) What steps will reproduce the problem? 1. View any diff I expect you to not use tables for layout. But you do. Please stop.
Feb 13, 2010
#1
sop@google.com
Feb 13, 2010
Start at http://www.hotdesign.com/seybold/ and follow the next links. Tables are for tabular data, not layout.
Feb 13, 2010
This is going to be beyond a pain in the a** to change. In a side-by-side view we basically have a two column format for the source code file; the left column contains the old file and the right column contains the new file. Its actually 4 columns if you include the line numbers, though sure you can get away with 2 columns if you pack the line numbers into spans and use CSS to force a proper alignment and margin. The comment editors and display panels are wedged into this as their own rows. Inserting and deleting the panels amounts to adding or removing the table row. The unified diff view and the side-by-side diff view share a lot of code between them. And the unified diff view is actually a 3 column format with the old and new line numbers, and the file text shown all in one presentation. Unless someone writes the patches to do this, its unlikely to get fixed. There is a lot of work to implement the same UI without a table, and its really abusive to CSS to implement what amounts to a 2 column layout without using a table.
Status:
WontFix
|
|
| ► Sign in to add a comment |