My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 444: Pushing a super-module with only git-link updates causes a crash.
1 person starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 438
Owner:  ulrik.sj...@gmail.com
Closed:  Feb 2010


Sign in to add a comment
 
Project Member Reported by ulrik.sj...@gmail.com, Feb 11, 2010
Affected Version: 2.1.2
Environment: All

What steps will reproduce the problem?
1. Create a project with git submodules and upload child and super project
2. Make a change to the child project, commit and upload
3. Update the super project and push
4. The push is performed but with a stack trace, since its just a gitlink 
update, Gerrit gets confused.

What is the expected output? What do you see instead?
The push should work and we should be able to approve and submit the 
change.

Please provide any additional information below.
[2010-02-11 14:38:58,950] INFO  com.google.gerrit.pgm.Daemon : Gerrit Code 
Review 2.1.1.1-90-g7e28358 ready
[2010-02-11 14:44:23,681] ERROR 
com.google.gerrit.server.cache.SelfPopulatingCache : Cannot lookup 
com.google.gerrit.server.patch.PatchListKey@5c934933 in "diff"
net.sf.ehcache.CacheException: Could not fetch object for cache entry with 
key "com.google.gerrit.server.patch.PatchListKey@5c934933".
                at 
net.sf.ehcache.constructs.blocking.SelfPopulatingCache.get
(SelfPopulatingCache.java:88)
                at com.google.gerrit.server.cache.SelfPopulatingCache.get
(SelfPopulatingCache.java:107)
                at com.google.gerrit.server.patch.PatchListCacheImpl.get
(PatchListCacheImpl.java:95)
                at com.google.gerrit.server.patch.PatchListCacheImpl.get
(PatchListCacheImpl.java:107)
                at com.google.gerrit.server.patch.PatchListCacheImpl.get
(PatchListCacheImpl.java:99)
                at com.google.gerrit.server.mail.OutgoingEmail.getPatchList
(OutgoingEmail.java:446)
                at 
com.google.gerrit.server.mail.OutgoingEmail.formatChangeDetail
(OutgoingEmail.java:436)
                at com.google.gerrit.server.mail.NewChangeSender.format
(NewChangeSender.java:64)
                at com.google.gerrit.server.mail.OutgoingEmail.send
(OutgoingEmail.java:157)
                at com.google.gerrit.server.git.ReceiveCommits.createChange
(ReceiveCommits.java:873)
                at 
com.google.gerrit.server.git.ReceiveCommits.createNewChanges
(ReceiveCommits.java:772)
                at com.google.gerrit.server.git.ReceiveCommits.onPreReceive
(ReceiveCommits.java:259)
                at org.eclipse.jgit.transport.ReceivePack.executeCommands
(ReceivePack.java:797)
                at org.eclipse.jgit.transport.ReceivePack.service
(ReceivePack.java:540)
                at org.eclipse.jgit.transport.ReceivePack.receive
(ReceivePack.java:486)
                at com.google.gerrit.sshd.commands.Receive.runImpl
(Receive.java:90)
                at com.google.gerrit.sshd.AbstractGitCommand.service
(AbstractGitCommand.java:94)
                at com.google.gerrit.sshd.AbstractGitCommand.access$0
(AbstractGitCommand.java:83)
                at com.google.gerrit.sshd.AbstractGitCommand$1.run
(AbstractGitCommand.java:65)
                at com.google.gerrit.sshd.BaseCommand$TaskThunk.run
(BaseCommand.java:376)
                at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:441)
                at java.util.concurrent.FutureTask$Sync.innerRun
(FutureTask.java:303)
                at java.util.concurrent.FutureTask.run(FutureTask.java:138)
                at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access
$301(ScheduledThreadPoolExecutor.java:98)
                at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run
(ScheduledThreadPoolExecutor.java:207)
                at com.google.gerrit.server.git.WorkQueue$Task.run
(WorkQueue.java:310)
                at java.util.concurrent.ThreadPoolExecutor$Worker.runTask
(ThreadPoolExecutor.java:886)
                at java.util.concurrent.ThreadPoolExecutor$Worker.run
(ThreadPoolExecutor.java:908)
                at java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.ArrayIndexOutOfBoundsException: -1
                at com.google.gerrit.server.patch.Text.getLines
(Text.java:65)
                at com.google.gerrit.server.patch.CharText.<init>
(CharText.java:23)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl.newEntry
(PatchListCacheImpl.java:224)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl.readPatchList
(PatchListCacheImpl.java:183)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl.compute
(PatchListCacheImpl.java:114)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl.access$0
(PatchListCacheImpl.java:110)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl$2.createEntry
(PatchListCacheImpl.java:89)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl$2.createEntry
(PatchListCacheImpl.java:1)
                at 
com.google.gerrit.server.cache.SelfPopulatingCache$1.createEntry
(SelfPopulatingCache.java:60)
                at 
net.sf.ehcache.constructs.blocking.SelfPopulatingCache.get
(SelfPopulatingCache.java:72)
                ... 28 more
[2010-02-11 14:44:23,684] ERROR com.google.gerrit.sshd.BaseCommand : 
Internal server error (user ulrik.sjolin account 1000000) during git-
receive-pack '/appsOnly'
java.lang.NullPointerException
                at 
com.google.gerrit.server.mail.OutgoingEmail.formatChangeDetail
(OutgoingEmail.java:436)
                at com.google.gerrit.server.mail.NewChangeSender.format
(NewChangeSender.java:64)
                at com.google.gerrit.server.mail.OutgoingEmail.send
(OutgoingEmail.java:157)
                at com.google.gerrit.server.git.ReceiveCommits.createChange
(ReceiveCommits.java:873)
                at 
com.google.gerrit.server.git.ReceiveCommits.createNewChanges
(ReceiveCommits.java:772)
                at com.google.gerrit.server.git.ReceiveCommits.onPreReceive
(ReceiveCommits.java:259)
                at org.eclipse.jgit.transport.ReceivePack.executeCommands
(ReceivePack.java:797)
                at org.eclipse.jgit.transport.ReceivePack.service
(ReceivePack.java:540)
                at org.eclipse.jgit.transport.ReceivePack.receive
(ReceivePack.java:486)
                at com.google.gerrit.sshd.commands.Receive.runImpl
(Receive.java:90)
                at com.google.gerrit.sshd.AbstractGitCommand.service
(AbstractGitCommand.java:94)
                at com.google.gerrit.sshd.AbstractGitCommand.access$0
(AbstractGitCommand.java:83)
                at com.google.gerrit.sshd.AbstractGitCommand$1.run
(AbstractGitCommand.java:65)
                at com.google.gerrit.sshd.BaseCommand$TaskThunk.run
(BaseCommand.java:376)
                at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:441)
                at java.util.concurrent.FutureTask$Sync.innerRun
(FutureTask.java:303)
                at java.util.concurrent.FutureTask.run(FutureTask.java:138)
                at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access
$301(ScheduledThreadPoolExecutor.java:98)
                at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run
(ScheduledThreadPoolExecutor.java:207)
                at com.google.gerrit.server.git.WorkQueue$Task.run
(WorkQueue.java:310)
                at java.util.concurrent.ThreadPoolExecutor$Worker.runTask
(ThreadPoolExecutor.java:886)
                at java.util.concurrent.ThreadPoolExecutor$Worker.run
(ThreadPoolExecutor.java:908)
                at java.lang.Thread.run(Thread.java:619)
[2010-02-11 14:47:07,245] ERROR 
com.google.gerrit.server.cache.SelfPopulatingCache : Cannot lookup 
com.google.gerrit.server.patch.PatchListKey@5c934933 in "diff"
net.sf.ehcache.CacheException: Could not fetch object for cache entry with 
key "com.google.gerrit.server.patch.PatchListKey@5c934933".
                at 
net.sf.ehcache.constructs.blocking.SelfPopulatingCache.get
(SelfPopulatingCache.java:88)
                at com.google.gerrit.server.cache.SelfPopulatingCache.get
(SelfPopulatingCache.java:107)
                at com.google.gerrit.server.patch.PatchListCacheImpl.get
(PatchListCacheImpl.java:95)
                at com.google.gerrit.server.patch.PatchListCacheImpl.get
(PatchListCacheImpl.java:107)
                at com.google.gerrit.server.patch.PatchListCacheImpl.get
(PatchListCacheImpl.java:99)
                at 
com.google.gerrit.httpd.rpc.changedetail.PatchSetDetailFactory.call
(PatchSetDetailFactory.java:83)
                at 
com.google.gerrit.httpd.rpc.changedetail.ChangeDetailFactory.loadCurrentPat
chSet(ChangeDetailFactory.java:188)
                at 
com.google.gerrit.httpd.rpc.changedetail.ChangeDetailFactory.call
(ChangeDetailFactory.java:108)
                at 
com.google.gerrit.httpd.rpc.changedetail.ChangeDetailFactory.call
(ChangeDetailFactory.java:1)
                at com.google.gerrit.httpd.rpc.Handler.to(Handler.java:65)
                at 
com.google.gerrit.httpd.rpc.changedetail.ChangeDetailServiceImpl.changeDeta
il(ChangeDetailServiceImpl.java:42)
                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native 
Method)
                at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:39)
                at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:25)
                at java.lang.reflect.Method.invoke(Method.java:597)
                at com.google.gwtjsonrpc.server.MethodHandle.invoke
(MethodHandle.java:91)
                at com.google.gwtjsonrpc.server.JsonServlet.doService
(JsonServlet.java:382)
                at com.google.gwtjsonrpc.server.JsonServlet.service
(JsonServlet.java:268)
                at javax.servlet.http.HttpServlet.service
(HttpServlet.java:820)
                at com.google.inject.servlet.ServletDefinition.doService
(ServletDefinition.java:216)
                at com.google.inject.servlet.ServletDefinition.service
(ServletDefinition.java:141)
                at com.google.inject.servlet.ManagedServletPipeline.service
(ManagedServletPipeline.java:93)
                at com.google.inject.servlet.FilterChainInvocation.doFilter
(FilterChainInvocation.java:63)
                at com.google.inject.servlet.FilterDefinition.doFilter
(FilterDefinition.java:134)
                at com.google.inject.servlet.FilterChainInvocation.doFilter
(FilterChainInvocation.java:59)
                at com.google.inject.servlet.FilterDefinition.doFilter
(FilterDefinition.java:134)
                at com.google.inject.servlet.FilterChainInvocation.doFilter
(FilterChainInvocation.java:59)
                at com.google.gwtexpui.server.CacheControlFilter.doFilter
(CacheControlFilter.java:76)
                at com.google.inject.servlet.FilterDefinition.doFilter
(FilterDefinition.java:129)
                at com.google.inject.servlet.FilterChainInvocation.doFilter
(FilterChainInvocation.java:59)
                at com.google.gerrit.httpd.RequestCleanupFilter.doFilter
(RequestCleanupFilter.java:54)
                at com.google.inject.servlet.FilterDefinition.doFilter
(FilterDefinition.java:129)
                at com.google.inject.servlet.FilterChainInvocation.doFilter
(FilterChainInvocation.java:59)
                at com.google.inject.servlet.FilterDefinition.doFilter
(FilterDefinition.java:134)
                at com.google.inject.servlet.FilterChainInvocation.doFilter
(FilterChainInvocation.java:59)
                at com.google.inject.servlet.ManagedFilterPipeline.dispatch
(ManagedFilterPipeline.java:122)
                at com.google.inject.servlet.GuiceFilter.doFilter
(GuiceFilter.java:110)
                at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter
(ServletHandler.java:1187)
                at org.eclipse.jetty.servlet.ServletHandler.doHandle
(ServletHandler.java:425)
                at org.eclipse.jetty.server.handler.ContextHandler.doHandle
(ContextHandler.java:931)
                at org.eclipse.jetty.servlet.ServletHandler.doScope
(ServletHandler.java:362)
                at org.eclipse.jetty.server.handler.ContextHandler.doScope
(ContextHandler.java:867)
                at org.eclipse.jetty.server.handler.ScopedHandler.handle
(ScopedHandler.java:117)
                at org.eclipse.jetty.server.handler.HandlerWrapper.handle
(HandlerWrapper.java:113)
                at 
org.eclipse.jetty.server.handler.RequestLogHandler.handle
(RequestLogHandler.java:50)
                at org.eclipse.jetty.server.handler.HandlerWrapper.handle
(HandlerWrapper.java:113)
                at org.eclipse.jetty.server.Server.handle(Server.java:334)
                at org.eclipse.jetty.server.HttpConnection.handleRequest
(HttpConnection.java:559)
                at 
org.eclipse.jetty.server.HttpConnection$RequestHandler.content
(HttpConnection.java:1007)
                at org.eclipse.jetty.http.HttpParser.parseNext
(HttpParser.java:747)
                at org.eclipse.jetty.http.HttpParser.parseAvailable
(HttpParser.java:209)
                at org.eclipse.jetty.server.HttpConnection.handle
(HttpConnection.java:406)
                at org.eclipse.jetty.io.nio.SelectChannelEndPoint.run
(SelectChannelEndPoint.java:462)
                at org.eclipse.jetty.util.thread.QueuedThreadPool$2.run
(QueuedThreadPool.java:436)
                at java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.ArrayIndexOutOfBoundsException: -1
                at com.google.gerrit.server.patch.Text.getLines
(Text.java:65)
                at com.google.gerrit.server.patch.CharText.<init>
(CharText.java:23)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl.newEntry
(PatchListCacheImpl.java:224)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl.readPatchList
(PatchListCacheImpl.java:183)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl.compute
(PatchListCacheImpl.java:114)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl.access$0
(PatchListCacheImpl.java:110)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl$2.createEntry
(PatchListCacheImpl.java:89)
                at 
com.google.gerrit.server.patch.PatchListCacheImpl$2.createEntry
(PatchListCacheImpl.java:1)
                at 
com.google.gerrit.server.cache.SelfPopulatingCache$1.createEntry
(SelfPopulatingCache.java:60)
                at 
net.sf.ehcache.constructs.blocking.SelfPopulatingCache.get
(SelfPopulatingCache.java:72)
                ... 54 more


Feb 11, 2010
#1 sop@google.com
I'm not surprised by this.  We don't exactly support gitlink well.
But we should.
Status: Accepted
Feb 13, 2010
#2 sop@google.com
Exact same bug as  issue 438 .
Status: Duplicate
Labels: -Milestone-2.1.2 FixedIn-2.1.2
Mergedinto: 438
Sign in to add a comment

Powered by Google Project Hosting