My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 405: configurable canned comments for changes
20 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  Shane...@gmail.com


Sign in to add a comment
 
Reported by t...@google.com, Jan 19, 2010
My most common response to a comment on one of my own CLs is "Done".  How 
about a button that enters that reply for me?
Jan 21, 2010
#1 sop@google.com
(No comment was entered for this change.)
Status: Accepted
Labels: Milestone-Next
Jan 21, 2010
Project Member #2 Shane...@gmail.com
Could we perhaps enhance this with per-project/per-user "canned responses" ? and also
allow it to be used on the main comments form?
Jan 26, 2010
#3 sop@google.com
I've started this in change If67ab6f71eaf30cd23a9cd67b5914ec63dbecdfc.

Thus far, I've only very crudely implemented the original request for
a canned "Done" reply button.  And by crude, I mean I don't like how
the UI flickers while its doing through the motions...

I'll try to revisit this tomorrow and see if I can't do something a
bit smarter while creating the canned "Done" draft.

ShaneMcC:  What sort of use case are you looking at for canned replies?
I've never found them useful beyond the standard LGTM thing we use, but
that's covered by the Code Review category vote.  tomo made a good point
about "Done", as its common to state that on each comment to make sure you
have addressed the issues.  But what else is common enough to justify a
canned response that isn't a category vote? "WontFix"?  "WhenPigsFly?"

Frankly, before we have more configurable canned replies, I'd like to have
a way to find comments you *didn't* reply to, because those are things you
have missed that the reviewer pointed out to you.  In a review with 80 line
comments, that could be a massive productivity improvement, far more so than
being able to use a configured canned reply of "WontFixIDontLikeYourIdea".
Status: Started
Owner: s...@google.com
Jan 27, 2010
#4 sop@google.com
(No comment was entered for this change.)
Status: Fixed
Labels: -Milestone-Next FixedIn-2.1.2
Jan 27, 2010
Project Member #5 Shane...@gmail.com
We have a CI script that runs on all submitted code, and it responds to commands left
in comments such as "recompile".

Also, often people leave sysouts in the code, or forget to javadoc, so it would be
nice to be able to just add these as comments quickly.
Jan 27, 2010
#6 sop@google.com
Thanks, that's a pretty good explanation for why this should be done.

The code I submitted to implement 'Done' is fairly generic, one
could add additional buttons into the PublishedCommentPanel at the
end of AbstractPatchContentPanel if they had the list from somewhere.
Should be pretty clear when you get into that code how the 'Done' is
wedged in, adding support for other texts should be simple.

I'm punting this to ShaneMcC because its just not important enough
to myself to spend time on this beyond the 'Done' canned reply.
Summary: configurable canned comments for changes
Status: Accepted
Owner: ShaneMcC
Jan 12, 2011
Project Member #7 mf...@codeaurora.org
I still think that a few extra canned responses would be very useful.  But, like Shawn, I only think that this is useful if there is a good way to keep track of things.  I envision perhaps adding state to a comment so that DONE can be tracked more easily.  Then add a REJECT and perhaps and OBE button and states also.

Ideally, once there are states, the main filelist table on the changeset could track these states and summarize them for each file and for the entire patchset.  But, even more importantly, it would summarize them for the current patchset and for the sum of all the patchsets up until this point!

So, ideally, if on patchset 1, I am the only one to make a suggestion, when patchset 2 is submitted, on the right somewhere near the reviewed checkmark there would be a summary perhaps like this D/R/O U (Done/Rejected/OBE Unanswered).  So if the suggestion was addressed, it would be 1/0/0  0.  But, if a comment was unanswered, it would be 0/0/0 1.  And perhaps the 1 would be in red to show that something may have been forgotten.  If you want to get fancy, the number could be a link to the latest comment meeting that particular criteria (since we can't yet link to individual comments, it could at least link to the file and the appropriate patchset where the comment lives).

Of course, this brings up the question of what to do when someone's comment invites another suggestion as a reply?  I would think that the initial comment should be treated as a thread and that the canned "status" replies apply to an entire thread before them.  So, if new replies comments are added after a DONE reply, those comments' state will still be unanswered.

While this may get a bit complicated, it would help immensely on projects with multiple reviewers and when patchsets get resubmitted often.  I don't do a lot of reviews yet, but on the few that I do, I find myself wondering when my comments are addressed, where they missed, ignored, forgotten or disliked?  But, yet I don't really want to be a nag.  If I were sure (I could tell) that a comment/suggestion were unanswered (and likely forgotten/missed), I would have no problem pointing it out again.  Otherwise, I feel torn.

If this works well, when a new patchset is uploaded, an author should be able to use the number linking feature to quickly address all the remaining open comments.

Sign in to add a comment

Powered by Google Project Hosting