My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 396: Report each commenting event, even if commenter didn't enter top-level text
4 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  mf...@codeaurora.org
Closed:  Mar 2012


Sign in to add a comment
 
Reported by stadlera...@gmail.com, Jan 19, 2010
Right now the main #change page provides a summary at the bottom of all comments made.  
Unfortunately, there's only a report line if the commenter makes a top-level comment.  They might 
make hundreds of line-by-line comments, but if they don't add a summary comment, there is no 
report at the main page.

I think it's important from both an audit trail perspective, and a "did I review this?" perspective.

I think it's sufficient to say something like "Patch Set 2: No score; No score" which is what you 
already say (if there was a comment).  It's a marker that somebody did something.

For extra points, maybe even add a note like "37 inline comments".

Jan 19, 2010
#1 sop@google.com
(No comment was entered for this change.)
Status: Accepted
Jun 11, 2010
#2 nas...@chromium.org
(No comment was entered for this change.)
Owner: mf...@codeaurora.org
Jun 15, 2010
#3 sop@google.com
Fixed by I1f7a1854b1a12d0ff5e5d27a5e077247b0fb4c71
Status: Fixed
Labels: FixedIn-2.1.3
Mar 27, 2012
#4 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting