My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 395: Button to open all files in CL in browser tabs
3 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2012


Sign in to add a comment
 
Reported by t...@google.com, Jan 19, 2010
It'd be nice to be able to click one button to open all of the files in the 
CL, rather than having to click separately on each file.  This would be 
faster and also reduce the chance that I miss one of the files accidentally.
Jan 21, 2010
#1 sop@google.com
(No comment was entered for this change.)
Status: Accepted
Jul 12, 2010
Project Member #2 ziv...@gmail.com
Implemented in this change:
https://review.source.android.com/#change,15728

Added two buttons "Diff all Side-by-Side" and "Diff all Unified".
This might not look the best in the UI... if there are better ideas
I am ready to improve it.

Jul 12, 2010
#3 t...@google.com
Thanks!
Jul 12, 2010
#4 sop@google.com
Fixed in Ie4138df0080fc92b7a451426f5dc1176283a6f55
Status: Fixed
Labels: FixedIn-2.1.4
Jul 14, 2010
Project Member #5 edwin.ke...@gmail.com
I noticed that the buttons to open all file diffs in own tabs are only displayed for the current patch set and only if the user is signed in. I've pushed a small change for review that causes the buttons to be always displayed: https://review.source.android.com/15794
Jul 14, 2010
Project Member #6 edwin.ke...@gmail.com
In Internet Explorer (version 6) both buttons to open the file diffs in own tabs are not working.
I get the following exception:
com.google.gwt.core.client.JavaScriptException: (Error): Invalid argument.
number: -2147024809
description: Invalid argument.
at com.google.gwt.dev.shell.BrowserChannelServer.invokeJavascript(BrowserChannelServer.java:195)
at com.google.gwt.dev.shell.ModuleSpaceOOPHM.doInvoke(ModuleSpaceOOPHM.java:120)
at com.google.gwt.dev.shell.ModuleSpace.invokeNative(ModuleSpace.java:507)
at com.google.gwt.dev.shell.ModuleSpace.invokeNativeObject(ModuleSpace.java:264)
at com.google.gwt.dev.shell.JavaScriptHost.invokeNativeObject(JavaScriptHost.java:91)
at com.google.gwt.core.client.impl.Impl.apply(Impl.java)
at com.google.gwt.core.client.impl.Impl.entry0(Impl.java:188)
at sun.reflect.GeneratedMethodAccessor25.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at com.google.gwt.dev.shell.MethodAdaptor.invoke(MethodAdaptor.java:103)
at com.google.gwt.dev.shell.MethodDispatch.invoke(MethodDispatch.java:71)
at com.google.gwt.dev.shell.OophmSessionHandler.invoke(OophmSessionHandler.java:157)
at com.google.gwt.dev.shell.BrowserChannel.reactToMessages(BrowserChannel.java:1668)
at com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChannelServer.java:401)
at com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java:222)
at java.lang.Thread.run(Thread.java:679)

Any ideas?
Jul 15, 2010
#7 sop@google.com
Very odd error.  Is this IE 6 failure only happening in hosted mode?
Status: AwaitingInformation
Labels: Browser-MSIE Milestone-2.1.4
Jul 15, 2010
Project Member #8 edwin.ke...@gmail.com
Sorry I should have said how I came to this stacktrace.

I get this stacktrace when running Gerrit in Debug mode (GWT Development Mode) and then clicking in IE6 on one of the Diff-All buttons.

If Gerrit is run by starting the daemon and then clicking in IE6 on one of the Diff-All buttons I don't get any exception logged (at least I didn't find any). Nevertheless clicking on the Diff-buttons is not working. After clicking on one of the buttons IE6 shows in the status line the message 'Error on page." together with some error icon.

The details for this error look like this:
Line: 3813
Char: 110
Error: Invalid argument
Code: 0
URL: http://127.0.0.1:8080/gerrit/B5400B659FECE46C4012134DFA04B974.cache.htm

Line is 3813 for 'Diff All Side-by-Side' button and 3814 for 'Diff All Unified' button.

By saving the page to the file system I got the corresponding html file 'B5400B659FECE46C4012134DFA04B974.cache.htm' which I'm attaching.
Not sure if this is helpful for the further investigation.


B5400B659FECE46C4012134DFA04B974.cache.htm
822 KB   Download
Jul 15, 2010
#9 sop@google.com
IE6 issue fixed in https://review.source.android.com/15845
Status: Fixed
Labels: -Browser-MSIE -Milestone-2.1.4
Mar 27, 2012
#10 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting