My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 391: Add an option to make approved patches be auto-submitted
14 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  mf...@codeaurora.org
Closed:  Mar 2012


Sign in to add a comment
 
Reported by dro...@gmail.com, Jan 15, 2010
Just to speed up my workflow slightly, saving me a few clicks, I'd like to
have an option such that after a patch gets the necessary +2 review, it
will automatically be submitted for merging. This will save the extra
clicks of going back to the change page and click the 'Submit changes' button.
Jan 21, 2010
#1 sop@google.com
Not everyone wants this behavior.  But some do.

I wonder, should this be a user preference, a project preference, or a
site/server preference?

Would it be sufficient to just add an additional "Publish and Submit"
button to the publish comments page?  So you can pick to publish the
comment, or publish and execute a submit, just by shifting the cursor
over a few pixels?
Status: Accepted
Jan 21, 2010
#2 dro...@gmail.com
Just adding a second "Publish and Submit" button would make me happy, and perhaps
make it more clear about what would happen next after they submitted the form, versus
having the submit happen in the background.
Jan 21, 2010
Project Member #3 Shane...@gmail.com
It would be nice to be able to set this on a per-project level.

We have a automatic script that takes all changes submitted to gerrit and attempts to
build them and run unit tests.

This often takes more time to complete than the actual code review. It would be nice
if it was possible to get the code automatically submitted when all the categories
are +MAX-ed.
Jan 29, 2010
Project Member #4 Shane...@gmail.com
 Issue 310  is probably easier to do, and combining that with the comment-added hook
would allow people to implement this functionality themselves by having the hook ssh
and submit the change set.
Jan 29, 2010
#5 sop@google.com
Yea, good point ShaneMcC.  Submit over ssh should be pretty simple.
But I still think we should enable a "Publish and Submit" button
in the web UI... at some point.
Jan 29, 2010
Project Member #6 Shane...@gmail.com
Yeh, would be nice as well.
Feb 18, 2010
#7 docw...@gmail.com
Also, when/how a submit happens should be documented someplace.  It wasn't clear to 
me after reading the docs... I didn't realize I had to do this via the command line by 
pushing to the direct branch (not the refs/for/branch).
Feb 18, 2010
#9 docw...@gmail.com
mike.lifeguard: I figured it out, eventually, but it isn't obvious. This should, however, be 
a separate issue.  When I posted comment 7, I didn't realize what the differences were. I 
*think* I do now.
Feb 18, 2010
#10 mike.lifeguard@gmail.com
Yes, the documentation is (as always) lacklustre. I may do some work on that in the
future...
Jun 3, 2010
Project Member #11 mf...@codeaurora.org
Having just offered a solution to  Issue 310  for review, I am now considering
approaches for this issue.  Ironically, I am coming to the conclusion that perhaps
the proposed solution of adding a new submit function via ssh was the wrong approach
for command line submissions.  I think that instead, we should perhaps rename the
approve command to review  (and provide a backward compatible alias for approve). 
Then, we could simply add a --submit option to this new review command.  This would
allow someone to verify, approve and submit all in one!  

By using this approach along with Shawn's suggestion of simply adding a "Publish and
Submit" button to the web UI, full functionality will have been achieved in a fairly
consistent way without having to add any special project (or other) level auto
submit policies while additionally reducing the command line command count and (I
believe) simplifying things.
Jun 3, 2010
#12 sop@google.com
OK, that makes a lot of sense.

Fortunately adding an alias is trivial, so we can keep `gerrit approve`
around for a while to retain backwards compatibility.
Jun 11, 2010
#13 nas...@chromium.org
(No comment was entered for this change.)
Owner: mf...@codeaurora.org
Jun 15, 2010
#14 sop@google.com
Fixed by change If9f3415be1378e9303afe34486dce557a926dc71
Status: Fixed
Labels: FixedIn-2.1.3
Mar 27, 2012
#15 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting