My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 389: Invalid commentlink expression causes page load failure
  Back to list
Status:  Released
Owner:  sop@google.com
Closed:  Oct 2012
Cc:  yuntao....@gmail.com


Sign in to add a comment
 
Project Member Reported by sop@google.com, Jan 15, 2010
Affected Version: 2.1.1

What steps will reproduce the problem?

Insert a bad regular expression in the comment link, e.g.:

 [commentlink "jira"]
   match = ((?i)IKMAP-\\d+)
   html = http://example.com/browse/$1

What is the expected output? What do you see instead?

Change pages (#change,NNN) fail to load, showing a blank screen
instead of the change content.

The problem here is JavaScript doesn't understand the (?i) marker
in the expression, and failed to compile it.  I think it tried to
read the ? as making the ( optional.

We should trap a bad expression and display an error message, not
let the page crash and fail to render.
Jan 15, 2010
#1 sop@google.com
(No comment was entered for this change.)
Labels: Milestone-Next
Jan 26, 2010
#2 sop@google.com
Fixed by change I7df945acc42f74ba48a9e167fecdb20f102522c8
Status: Fixed
Labels: -Milestone-Next FixedIn-2.1.2
Oct 21, 2012
#3 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting