My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 384: Provide a way to CC interested parties without making them reviewers
52 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


Sign in to add a comment
 
Reported by t...@google.com, Jan 11, 2010
It'd be nice if I could CC somebody in a review without making it look like 
I expect them to do the review.  E.g., I might think they need a heads up  
about the CL or want to look at just one part of it.
Jan 11, 2010
#1 sop@google.com
Yea, good point.

You can do this in the commit message by adding a CC: line in the footer area
before uploading, e.g.:

  Fix the frobinator

  The frobinator was busted.  Fix it so its less busted.

  CC: <bob@example.com>
  Change-Id: Ic0ffee...

But then its part of the message for all time.  You can force a CC during
upload if you pass the right command line flags for --cc [1], but this is
not as simple as having the web UI support CC directly.

[1] http://gerrit.googlecode.com/svn/documentation/2.1/user-upload.html#push_create
Status: Accepted
Sep 1, 2010
#2 di...@google.com
This seems related to another issue but both could be fixed if Gerrit would store and maintain/manage a list of CC along the list of reviewers. It should initialize the CC list with whatever is given on the upload command (or some default value that could be configured per project, here it might also be useful to support somehow that the default value is added to the CC list not overwritten by the upload command CC values). Then this way people that were originally CC-ed by the initial upload command will also be CCed in further review comments unlike now where Gerrit loses that information.

I don't like the Git description solution because it's yet another magic added to the description and adds to the risk of leaking internal list information to the public when publishing commits upstream.
Sep 29, 2010
#3 jsh...@google.com
I envision a box below the Reviewer section that would work exactly the same, but have a list of Cc: recipients and have an "Add Cc:" button. And it should work with upload --cc the same way it does with upload --re. But then again, I think that's what we all had in mind.
Sep 29, 2010
#4 t...@google.com
sgtm
Sep 29, 2010
#5 di...@google.com
Yep, that would be great :)
Mar 13, 2015
#6 redd...@google.com
I would like this, too.
Apr 24, 2015
#7 jeffbing...@google.com
This is something that would be very useful for me.
Jul 14, 2015
#8 hi...@google.com
I'd like to add our team mailling-list address (non-human address) to my changes, but it should not reviewer. I want CC feature for this purpose.
Jul 14, 2015
Project Member #9 edwin.ke...@gmail.com
 > I'd like to add our team mailling-list address (non-human address) to my changes

If you want this for all changes, you can configure this on project level [1].

[1] https://gerrit-review.googlesource.com/Documentation/user-notify.html#project
Jul 16, 2015
#10 namrata....@gmail.com
Please see my comment on Issue #1187: https://code.google.com/p/gerrit/issues/detail?id=1187

Reproducing it here for reference:

It would be very helpful if we could have separate fields such as:

Primary reviewer:
Secondary reviewers:
Approver (or Gate-Keeper):
Verifier:
FYI-Only:

It would also be helpful to have a "Waiting-On" field. This could be used to tag a specific person that needs to look at a given patchset. Often, 1 of the 5 reviewers will comment, then the author will update the review based on those comments. So now the ball is in Reviewer1's court. This should be possible to indicate clearly.

Also, once this is implemented, there should be a way to categorize your dashboard based on your role. E.g. there should be a section for all patches for which you are primary reviewer, a separate section for all patches where you are the verifier, and so on.
Sign in to add a comment

Powered by Google Project Hosting