My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 375: Support commit with rebase
1 person starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  Jan 2010


Sign in to add a comment
 
Reported by alex.ble...@gmail.com, Jan 6, 2010
When submitting a review which has been built up of many changes, sometimes there's a request 
to collapse all the commits into a single change to push. Instead of having to abandon a change, 
and then re-push everything, Gerrit could do the rebase on behalf of the user whilst committing.
Jan 11, 2010
#1 sop@google.com
I'm not sure we want to do this.

One of the things we're striving for is to have what you review be what
is submitted to the branch.  Fudging around and squashing multiple change
records into one commit is really starting to play games with the intent
of the review.

Gerrit Code Review wasn't intended to be a replacement for the other Git
tools that are out there, its only meant to help you examine a change,
discuss it, and if its considered ready for inclusion, put it into the
project.  Doing a squash probably implies there are even more corrections
needed, like writing a proper commit message for the squashed set.  That's
starting into the area of "editing".  At that point we might want to just
consider a "workspace in the cloud" and let you edit a change without doing
a checkout locally first.

Which might not be a bad feature; we can store the workspace in a branch or
a change record and let you edit it, each revision creating a new patch set.

Status: WontFix
Labels: -Type-Bug Type-Feature
Sign in to add a comment

Powered by Google Project Hosting