My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3694: Gerrit v2.12_rc1 slave needs Lucene
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Dec 3


Sign in to add a comment
 
Reported by sven.sel...@sonymobile.com, Nov 24, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: v2.12_rc1

What steps will reproduce the problem?
1. Start gerrit as slave 

What is the expected output? What do you see instead?
Start fails with [1]

Please provide any additional information below.

I beleive this is caused by:
https://gerrit-review.googlesource.com/#/c/71107 - Only bind index ssh commands when the index type is Lucene

Which adds IndexCommandModule as childmodule to SshModule if indexType is set.
indexType was previously set locally in Daemon.java:382, but in this commit it is set on class level by IndexModule.getIndexType(cfgInjector) which defaults to IndexType.LUCENE (IndexModule.java:47) so even if index is not configured, it's now LUCENE.
IndexCommandModule in its turn configures IndexStartCommand.java and IndexActivateCommand.java that in turn have dependencies that a gerrit slave doesn't fulfill.

[1]
[main] ERROR com.google.gerrit.pgm.Daemon : Unable to start daemon
com.google.inject.CreationException: Unable to create injector, see the following errors:
[full stacktrace]
http://pastebin.com/wX4yqYNR

Nov 24, 2015
Project Member #1 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/72743
Status: ChangeUnderReview
Nov 24, 2015
Project Member #2 david.pu...@sonymobile.com
 Issue 3696  has been merged into this issue.
Nov 25, 2015
#3 sven.sel...@sonymobile.com
1. https://gerrit-review.googlesource.com/72743 still doesn't start withouth canonicalWebUrl configured, so it seems like it doesn't fix  issue 3696 .

2. You can start gerrit slave with:
  java -jar bin/gerrit.war daemon --slave --console-log
but if you try:
sudo service gerrit2 start
It silently fails.
It seem to get stuck in the loop at [1] since {gerrit site}/logs/gerrit.run is not created.

[1] https://gerrit.googlesource.com/gerrit/+/v2.12-rc1/gerrit-pgm/src/main/resources/com/google/gerrit/pgm/init/gerrit.sh#439

    while running "$GERRIT_PID" && test $TIMEOUT -gt 0 ; do
      if test "x$RUN_ID" = "x`cat $GERRIT_RUN 2>/dev/null`" ; then
        echo OK
        exit 0
      fi
      sleep 2
      TIMEOUT=`expr $TIMEOUT - 2`
    done
    echo FAILED
    exit 1
  ;;
Nov 25, 2015
#4 sven.sel...@sonymobile.com
P.s.
When running with java -jar bin/gerrit.war daemon --slave
{gerrit site}/logs/gerrit.run is created.
Dec 3, 2015
Project Member #5 ekem...@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.12
Dec 21, 2015
Project Member #6 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting