My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3543: Submit button title "Submit including parents" is too long.
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----
Cc:  sbel...@google.com


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Aug 31, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: master

What steps will reproduce the problem?
1. Have a series of 4 changes 1->2->3->4
2. Approve and verify 1-3, leave 4 unapproved
3. Open change 3.

What is the expected output? What do you see instead?

The submit button says "Submit including parents", but the parent change (4) cannot be submitted.

Please provide any additional information below.

Also, the title of the button is quite long, so it can no longer be rendered on the same line as the others.

I can't add an attachment due to "Issue attachment storage quota exceeded", so I've put a screenshot here:

http://imgur.com/LLv22ZP
Aug 31, 2015
#1 jrnieder
Change 4 isn't a parent --- it is a child.
Aug 31, 2015
Project Member #2 david.pu...@sonymobile.com
Yes, I just realised the same and was updating at the same time as you.

Let's make this issue only about the button length, and I'll go and get more coffee.

Summary: Submit button title "Submit including parents" is too long. (was: Submit button title is "Submit including parents" for change whose parent cannot be submitted)
Sign in to add a comment

Powered by Google Project Hosting