My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3531: Unified diff fails with server-side exception for AnonymousUser
3 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Oct 13


Sign in to add a comment
 
Reported by tw201...@gmail.com, Aug 24, 2015
Affected Version: 2.11.2

What steps will reproduce the problem?
1. Visit https://git.eclipse.org/r/#/c/54350/1/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/RefDirectory.java,unified (not logged in)

What is the expected output? What do you see instead?

Expected: Unified diff is shown.
Actual: gray screen of death (Internal server error).

Please provide any additional information below.

Side-by-side diff displays fine at https://git.eclipse.org/r/#/c/54350/1/org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/RefDirectory.java

Also occurs on a company-internal Gerrit instance, also running Gerrit 2.11.2, where I get the exception trace:

WARN  / : Error in patchSetDetail
java.lang.ClassCastException: com.google.gerrit.server.AnonymousUser cannot be cast to com.google.gerrit.server.IdentifiedUser
        at com.google.gerrit.server.change.RevisionResource.getUser(RevisionResource.java:87)
        at com.google.gerrit.server.change.Submit.getDescription(Submit.java:280)
        at com.google.gerrit.server.change.Submit.getDescription(Submit.java:89)
        at com.google.gerrit.server.extensions.webui.UiActions$4.apply(UiActions.java:118)
        at com.google.gerrit.server.extensions.webui.UiActions$4.apply(UiActions.java:88)
        at com.google.common.collect.Iterators$8.transform(Iterators.java:799)
        at com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
        at com.google.common.collect.Iterators$7.computeNext(Iterators.java:651)
        at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
        at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
        at com.google.common.collect.Iterators$7.computeNext(Iterators.java:650)
        at com.google.common.collect.AbstractIterator.tryToComputeNext(AbstractIterator.java:143)
        at com.google.common.collect.AbstractIterator.hasNext(AbstractIterator.java:138)
        at com.google.common.collect.Iterators.addAll(Iterators.java:361)
        at com.google.common.collect.Lists.newArrayList(Lists.java:160)
        at com.google.common.collect.Lists.newArrayList(Lists.java:144)
        at com.google.gerrit.server.extensions.webui.UiActions.sorted(UiActions.java:54)
        at com.google.gerrit.httpd.rpc.changedetail.PatchSetDetailFactory.call(PatchSetDetailFactory.java:219)
        at com.google.gerrit.httpd.rpc.changedetail.PatchSetDetailFactory.call(PatchSetDetailFactory.java:72)
        at com.google.gerrit.httpd.rpc.Handler.to(Handler.java:65)
        at com.google.gerrit.httpd.rpc.changedetail.ChangeDetailServiceImpl.patchSetDetail2(ChangeDetailServiceImpl.java:42)
        at com.google.gerrit.httpd.rpc.changedetail.ChangeDetailServiceImpl.patchSetDetail(ChangeDetailServiceImpl.java:36)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:497)
        at com.google.gwtjsonrpc.server.MethodHandle.invoke(MethodHandle.java:91)
        at com.google.gwtjsonrpc.server.JsonServlet.doService(JsonServlet.java:381)
        at com.google.gwtjsonrpc.server.JsonServlet.service(JsonServlet.java:267)
        at com.google.gerrit.httpd.rpc.GerritJsonServlet.service(GerritJsonServlet.java:120)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:725)
        at com.google.inject.servlet.ServletDefinition.doServiceImpl(ServletDefinition.java:279)
        at com.google.inject.servlet.ServletDefinition.doService(ServletDefinition.java:269)
        at com.google.inject.servlet.ServletDefinition.service(ServletDefinition.java:180)
        at com.google.inject.servlet.ManagedServletPipeline.service(ManagedServletPipeline.java:91)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:85)
        at com.google.gerrit.httpd.GetUserFilter.doFilter(GetUserFilter.java:82)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.gwtexpui.server.CacheControlFilter.doFilter(CacheControlFilter.java:73)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.gerrit.httpd.RunAsFilter.doFilter(RunAsFilter.java:117)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy$1.doFilter(AllRequestFilter.java:64)
        at com.google.gerrit.httpd.AllRequestFilter$FilterProxy.doFilter(AllRequestFilter.java:57)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.gerrit.httpd.RequestContextFilter.doFilter(RequestContextFilter.java:75)
        at com.google.inject.servlet.FilterChainInvocation.doFilter(FilterChainInvocation.java:82)
        at com.google.inject.servlet.ManagedFilterPipeline.dispatch(ManagedFilterPipeline.java:119)
        at com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:133)
        at com.google.inject.servlet.GuiceFilter$1.call(GuiceFilter.java:130)
        at com.google.inject.servlet.GuiceFilter$Context.call(GuiceFilter.java:203)
        at com.google.inject.servlet.GuiceFilter.doFilter(GuiceFilter.java:130)
        at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
        at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
        at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:221)
        at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
        at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
        at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
        at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
        at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
        at org.eclipse.jetty.server.handler.RequestLogHandler.handle(RequestLogHandler.java:95)
        at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
        at org.eclipse.jetty.server.Server.handle(Server.java:497)
        at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)
        at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
        at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
        at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
        at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
        at java.lang.Thread.run(Thread.java:745)

Sep 22, 2015
#1 denis....@eclipse.org
Let me know if you need more details.  That stack trace is polluting my error_log
Oct 13, 2015
Project Member #2 David.Os...@gmail.com
 Issue 3599  has been merged into this issue.
Cc: david.pu...@sonymobile.com sbel...@google.com
Oct 13, 2015
Project Member #3 David.Os...@gmail.com
https://gerrit-review.googlesource.com/71500
Status: ChangeUnderReview
Labels: -Priority-Minor Priority-Major
Oct 13, 2015
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.11.4
Oct 15, 2015
Project Member #5 David.Os...@gmail.com
(No comment was entered for this change.)
Status: Released
Cc: -david.pu...@sonymobile.com -sbel...@google.com
Sign in to add a comment

Powered by Google Project Hosting