| Issue 3520: | Command git-review --list fails on windows when there are no changes already pushed | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Affected Version:
git-review-script.py version 1.24
What steps will reproduce the problem?
1. On windows, run "git-review --list" when there is NO changes present in Gerrit.
What is the expected output? (like on Linux):
$ git-review --list
# => Found 0 items for review
What I'm getting:
$ git-review --list
Traceback (most recent call last):
File "C:\Python34\Scripts\git-review-script.py", line 9, in <module>
load_entry_point('git-review==1.24', 'console_scripts', 'git-review')()
File "C:\Python34\lib\site-packages\git_review\cmd.py", line 1192, in main
list_reviews(remote)
File "C:\Python34\lib\site-packages\git_review\cmd.py", line 805, in list_reviews
review_field_width[i] = max(len(r[i]) for r in review_list)
ValueError: max() arg is an empty sequence
When there is at least one change pushed to Gerrit, option '--list' works fine.
thanks!
Aug 15, 2015
#1
tw201...@gmail.com
Aug 16, 2015
Heh, I don't know why I thought git-review was actually a part of Gerrit.. You were right, when I've upgraded to 1.25 (pip install --upgrade git-review) the problem has gone. I'm seeing "No pending reviews" message now (Note that is different than on Linux :) ) Thanks!
Aug 16, 2015
Also, feel free to close this issue.
Aug 17, 2015
(No comment was entered for this change.)
Status:
Invalid
|
|
| ► Sign in to add a comment |