My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3520: Command git-review --list fails on windows when there are no changes already pushed
1 person starred this issue and may be notified of changes. Back to list
Status:  Invalid
Owner:  ----
Closed:  Aug 17


Sign in to add a comment
 
Reported by marek.ko...@gmail.com, Aug 13, 2015
Affected Version:
  git-review-script.py version 1.24

What steps will reproduce the problem?
1. On windows, run "git-review --list" when there is NO changes present in Gerrit.

What is the expected output? (like on Linux):

  $ git-review --list
  # => Found 0 items for review

What I'm getting:

  $ git-review --list
  Traceback (most recent call last):
    File "C:\Python34\Scripts\git-review-script.py", line 9, in <module>
      load_entry_point('git-review==1.24', 'console_scripts', 'git-review')()
    File "C:\Python34\lib\site-packages\git_review\cmd.py", line 1192, in main
      list_reviews(remote)
    File "C:\Python34\lib\site-packages\git_review\cmd.py", line 805, in list_reviews
      review_field_width[i] = max(len(r[i]) for r in review_list)
  ValueError: max() arg is an empty sequence


When there is at least one change pushed to Gerrit, option '--list' works fine.


thanks!

Aug 15, 2015
#1 tw201...@gmail.com
This seems to be a bug in OpenStack git-review at https://github.com/openstack-infra/git-review , not in Gerrit.

Update to 1.25; that should have a fix for this: https://github.com/openstack-infra/git-review/commit/7aca8e69c merged on Jul 29, 2014 in https://github.com/openstack-infra/git-review/commit/0a91b0ba .
Aug 16, 2015
#2 marek.ko...@gmail.com
Heh, I don't know why I thought git-review was actually a part of Gerrit.. 

You were right, when I've upgraded to 1.25 (pip install --upgrade git-review) the problem has gone. I'm seeing "No pending reviews" message now (Note that is different than on Linux :) )

Thanks!

Aug 16, 2015
#3 marek.ko...@gmail.com
Also, feel free to close this issue.
Aug 17, 2015
Project Member #4 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Invalid
Sign in to add a comment

Powered by Google Project Hosting