| Issue 3508: | Diffs for filenames containing a pound character (#) causes java.lang.StringIndexOutOfBoundsException | |
| 2 people starred this issue and may be notified of changes. | Back to list |
Viewing the diff of a file that contains a pound character (#) in the filename causes a java.lang.StringIndexOutOfBoundsException. This only reproduces when using the new screen, it does not happen when using the old screen. Affected Version: 2.10.6 with new screen. Seems like it's fixed on gerrit-review.googlesource.com (ver 2.11.2-1089-gd7d7f68) test at https://gerrit-review.googlesource.com/#/c/70055 What steps will reproduce the problem? 1. Make sure your profile is set to use the gerrit new screen. 2. upload a change with a filename that contains a pound character in the filename. I tested with the following files in one single change: #jabberwocky.txt jabber#wocky.txt jabberwocky# jabberwocky.txt 3. view the change on Gerrit UI, then click on the files to view the diff. What is the expected output? What do you see instead? The only file that works is 'jabberwocky.txt'. When I click on the files with the pound sign I get a '500 Server Error' and log[1] reports 'java.lang.StringIndexOutOfBoundsException: String index out of range'. [1] http://paste.openstack.org/show/406915/
Aug 11, 2015
Project Member
#1
edwin.ke...@gmail.com
Aug 12, 2015
As pointed out in issue description, this bug only reproduces on version 2.10. I just ran another test, this time removing the javamelody plugin from my gerrit instance, and it still repros. Gerrit stack trace _without_ the javamelody plugin: http://paste.openstack.org/show/412806/
Aug 20, 2015
This is fixed in 2.11. I do not think there is plan for another release in 2.10, can we close this issue as fixed in 2.11?
Oct 8, 2015
This looks like it's still a problem on Gerrit 2.11.3. Take a look at this change https://review-dev.openstack.org/#/c/5362 Only the file without the # in it will render. For the other file UI shows '500' error and here is the error from the log: http://paste.openstack.org/show/475817/
Oct 13, 2015
I guess there must be something wonky with our site (it was migrated from Gerrit 2.8->2.10->2.11). I can't seem to reproduce this issue when test with a new 2.11 site locally :(
Dec 15, 2015
I can no longer repro this after upgrading to 2.11.4
Status:
CannotReproduce
|
|
| ► Sign in to add a comment |