My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 35: Gerrit2 should handle wide commit description messages better
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Jack Palevich <jackpal@google.com> on Mon Jan 26 13:03:46 PST 2009
Source: JIRA GERRIT-35
Affected Version: 2.0
Environment: Firefox 3.1 OSX

Check out how wide this message is, due to the very long second line of the
Description field:

http://review.source.android.com/Gerrit#change,6041

In case the text gets changed, at the time this bug was filed the text was:

Contribution of IA-32 assembly for the fast byte-code engine.
This contribution is the IA-32 assembly implementation for the fast byte-code
interpreter engine. This is an initial contribution with minimal optimizations
that target the Intel ATOM processor. We expect to continuously improve the
IA-32 fast interpreter. This contribution is expected to elicit discussion on
the potential merge of this code and similar efforts (i.e. the mterp/x86
directory included with cupcake). Using the simulator build for AOSP master we
were able to show the following improvements against the c-portable
interpreter:
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Mar 30 08:58:10 PDT 2009

Really, commit messages should be hard line-wrapped by the author at ~70-74
columns, so that tools like "git log" can display the message correctly.
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Mar 30 08:58:12 PDT 2009
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Mar 30 16:17:36 PDT 2009
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Mon Mar 30 16:17:42 PDT 2009

Fixed by https://review.source.android.com/9438
Sep 24, 2009
#5 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Mon Mar 30 16:17:42 PDT 2009

Fixed in version 2.0.9.
Status: Fixed
Sep 25, 2009
#6 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.9
Oct 25, 2012
#7 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting