My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 348: Comment on a patchset should be linkable/bookmarkable
36 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  sop@google.com
Closed:  Dec 2013

Blocking:
issue 93


Sign in to add a comment
 
Reported by mykola.nickishov, Dec 1, 2009
There is no way to link to a specific comment on a patchset outside of
Gerrit and discuss it in a mailing list, for instance, by providing a
direct URL to the comment in question.
Dec 1, 2009
#1 sop@google.com
This is perhaps a bit harder than we'd like it to be, because we use the anchor 
portion of the URL to specify a "page", rather than the standard use to specify
what section of the page the browser should scroll down to.

We might be able to use a per-comment URL like "#change,42,3" to indicate the
3rd comment on the change and then manually (via JavaScript) force the browser
to scroll to the 3rd comment upon loading the page.
Status: Accepted
Aug 12, 2010
Project Member #2 mf...@codeaurora.org
Or perhaps you could make a link to a comment simply display that comment with some context around it, but not the rest of the file.  In other words, do not scroll, simply display a reduced diff.
May 19, 2011
Project Member #3 nas...@grainawi.org
(No comment was entered for this change.)
Blocking: 93
May 19, 2011
Project Member #4 nas...@grainawi.org
 Issue 740  has been merged into this issue.
Oct 7, 2011
#5 pierre.h...@intersec-group.com
Seconded, espcecially the laconic:


>   Patch Set 2: (3 inline comments)

In the main view is annoying, it'd be really nice to have:

file foo: comment on lines <a href=...>nnn</a>, <a href=...>mmm</a>
file bar: comment on line <a href=...>ttt</a>

Right now having to guess which comments are "new" is mildly annoying, especially for really large patches (especially since "marking" a comment as done is done through ... generating a new one…).
Sep 20, 2013
Project Member #6 jrn@google.com
See comment 1 above, the diff view code at [1] (diffChunkNav() is an example of programatically scrolling to a line), and the code for dispatching based on anchor on line 619 of [2] if you'd like to work on this.

[1] https://gerrit.googlesource.com/gerrit/+/8e0f6d06/gerrit-gwtui/src/main/java/com/google/gerrit/client/diff/SideBySide2.java
[2] https://gerrit.googlesource.com/gerrit/+/master/gerrit-gwtui/src/main/java/com/google/gerrit/client/Dispatcher.java
Dec 13, 2013
#7 sop@google.com
(No comment was entered for this change.)
Labels: Blocking-2.9
Dec 18, 2013
#8 sop@google.com
https://gerrit-review.googlesource.com/53311
Status: ChangeUnderReview
Owner: sop@google.com
Dec 20, 2013
#9 sop@google.com
(No comment was entered for this change.)
Status: Submitted
Labels: -Blocking-2.9 FixedIn-2.9
Jul 18, 2014
Project Member #10 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting