My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3477: Side-by-side not accessible for changes with current draft PS
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  david.pu...@sonymobile.com
Closed:  Aug 4
Cc:  David.Os...@gmail.com


Sign in to add a comment
 
Reported by org...@gmail.com, Jul 15, 2015
Affected Version: 2.11

What steps will reproduce the problem?
1. Push a commit to gerrit
2. Amend the commit and push it as a draft
3. Try to open side-by-side diff for PS1 as a user that is not a reviewer of the change.

What is the expected output? What do you see instead?
Nothing happens. Since PS1 is not a draft, it should be visible.

Please provide any additional information below.
If you add yourself as a reviewer, you can access the diff, and you can access the draft PS (but that's a separate bug).
Aug 1, 2015
#1 org...@gmail.com
ping
Aug 3, 2015
Project Member #2 david.pu...@sonymobile.com
Will look into this.
Owner: david.pu...@sonymobile.com
Aug 3, 2015
Project Member #3 david.pu...@sonymobile.com
Console is showing this error:

Mon Aug 03 18:38:30 GMT+900 2015 Class$S631
SEVERE: (TypeError) : Cannot read property '_number' of undefinedClass$S123: (TypeError) : Cannot read property '_number' of undefined
	at Unknown.$_number_0(gerrit_ui-0.js)
	at Unknown.onSuccess_262(gerrit_ui-2.js)
	at Unknown.onSuccess_263(gerrit_ui-2.js)
	at Unknown.applySuccess(gerrit_ui-0.js)
	at Unknown.apply_2(gerrit_ui-0.js)
	at Unknown.success(gerrit_ui-0.js)
	at Unknown.onSuccess_311(gerrit_ui-0.js)
	at Unknown.onSuccess_316(gerrit_ui-0.js)
	at Unknown.execute_21(gerrit_ui-0.js)
	at Unknown.onResponseReceived_0(gerrit_ui-0.js)
	at Unknown.fireOnResponseReceived(gerrit_ui-0.js)
	at Unknown.onReadyStateChange(gerrit_ui-0.js)
	at Unknown.<anonymous>(gerrit_ui-0.js)
	at Unknown.apply_8(gerrit_ui-0.js)
	at Unknown.entry0(gerrit_ui-0.js)
	at Unknown.<anonymous>(gerrit_ui-0.js)
Aug 3, 2015
Project Member #5 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Accepted
Cc: David.Os...@gmail.com
Aug 3, 2015
Project Member #6 david.pu...@sonymobile.com
> and you can access the draft PS (but that's a separate bug).

This part is not a bug.  It is intentional that reviewers can see draft patch sets.
Aug 3, 2015
Project Member #7 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/70040/
Status: ChangeUnderReview
Aug 4, 2015
Project Member #8 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.11.3
Aug 20, 2015
Project Member #9 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting