My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3416: Related changes list is out of order or with incorrect ~ marks
4 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Nov 6


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Jun 9, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: master

What steps will reproduce the problem?
1. Upload a series of changes
2.
3.

What is the expected output? What do you see instead?

When looking at the related changes, the changes should be listed in order of the sequence that the commits were made in git.

Instead they are sometimes listed in some other order.  Sometimes the ~ marks for outdated changes are also wrongly added.

Please provide any additional information below.

For example this change [1] is the bottom change in a series, but is shown in the middle of the list.

[1] https://gerrit-review.googlesource.com/#/c/68542/

Screen Shot 2015-06-09 at 9.22.01 PM.png
50.4 KB   View   Download
Jun 9, 2015
Project Member #1 david.pu...@sonymobile.com
When looking at [2] the changes are in the correct sequence, but some of them are incorrectly showing the ~ mark to indicate an out of date dependency:

All of the links actually point to the latest patch set of the change.

[2] https://gerrit-review.googlesource.com/#/c/67771/
Screen Shot 2015-06-09 at 9.24.09 PM.png
217 KB   View   Download
Summary: Related changes list is out of order or with incorrect ~ marks (was: Related changes list is out of order)
Jun 9, 2015
Project Member #2 David.Os...@gmail.com
Do we have here some kind of caching problems?

I think I am seeing this problem with this series: [1].
However, sometimes it works and sometimes it doesn't,
when opening the same change, the latest one from the
series [2].

Sometimes the list of related changes is not only out
of order, but even worth: it is incomplete.

Consider this series: [1]. When the latest change from this series 
is opened: [2], then the order of related changes is correct and the
list is complete. But, after working a while in Chrome, I saw the
right order, but now the order in Chrome is wrong and the list is
incomplete: [3]. However, when the same is opened for the first time
in Firefox, the related change list is complete and the order is
correct: [4].

Another observation (a coincidense?) is that the wrong order of related
changes, shown in [3], matches exactly with the order when the changes
in the topic are listed on the list change screen, that corresponds to
this query: [1]. Screenshot: [5].

[1] https://gerrit-review.googlesource.com/#/q/topic:inline-4+status:open
[2] https://gerrit-review.googlesource.com/68143
[3] http://imgur.com/E706v9T [Chrome, working a while, wrong and incomplete]
[4] http://imgur.com/8WVwSjy [Firefox, opened first time, correct and complete]
[5] http://imgur.com/IGaA37F

Labels: -Priority-Minor Priority-Major
Jun 10, 2015
Project Member #3 David.Os...@gmail.com
Opps, for some reasons "Same Topic" tab was actived on change screen,
and not "Related Changes". That's annoying. I would like to always see
"Related Changes". But my previous comment is not related to this bug,
then.
Jun 20, 2015
Project Member #4 David.Os...@gmail.com
Can it be, that the order gets broken after Rebase from the UI, and
PatchSet.groups is not get updated?

Consider the mentioned series in my previous comment. After rebasing
parts of it, the order is broken and the changes are missing: [1],
when looking at the latest patch set of this change: [2].

However, the order is still correct, when looking at theprevious patch
set: [3], before the rebase operation from the UI: [4].

So the workaround to rebase the whole series from the UI could be:

* Position on the some ancient patch set of specific change, where
the order was correct
* Make a screen shot of the Related Changed tab
* Open the series with the latest patch sets with broken order and
missing changes on Related Changes tab
* Consult the screen shot to rebase all changes from the series in
the right order

After applying this workaround the order is correct again, when looking
at the last change in the series: [5]. But, the changes are still
missing, when looking at the first three changes in the series: [6],
after another change was pushed on top of them: [7].

[1] http://imgur.com/RK24EBq
[2] https://gerrit-review.googlesource.com/#/c/67860/8
[3] https://gerrit-review.googlesource.com/#/c/67860/5
[4] http://imgur.com/6WMYDly
[5] http://imgur.com/JMqlf0b
[6] http://imgur.com/chEv1uZ
[7] https://gerrit-review.googlesource.com/#/c/61604/12
Jun 20, 2015
Project Member #5 David.Os...@gmail.com
So, now all changes are rebased, and wrong changes are shown on
Related Changs tab:

Expected changes with correct order:

  $ git log --oneline
  ac27a68 InlineEdit: Add keyboard shortcuts help for VIM mode
  1f74e5c InlineEdit: Allow to activate auto-close brackets Codemirror addon
  5a73487 InlineEdit: Allow to activate match brackets Codemirror addon
  091d31c InlineEdit: Make cursor blink rate customizable
  c2085f3 InlineEdit: Support Emacs and Vim key maps
  2182ec8 InlineEdit: Register all keys in registerKeys() method
  7c58cc3 InlineEdit: Allow to save/load user preferences in Codemirror
  5b93ac8 Store and load edit preferences to/from All-Users repository
  54acc99 Store and load user preferences to/from All-Users repository

Actual changes shown:

ac27a68 InlineEdit: Add keyboard shortcuts help for VIM mode
4291c4f SideBySide: Allow to activate match brackets Codemirror addon
aa0c603 SideBySide: Make cursor blink rate customizable
41fb4fa Replace ACCOUNT_DIFF_PREFERENCES table with Git backend
1f74e5c InlineEdit: Allow to activate auto-close brackets Codemirror addon
[...]

Jun 29, 2015
Project Member #6 David.Os...@gmail.com
https://gerrit-review.googlesource.com/69154
Status: ChangeUnderReview
Labels: -Priority-Major Priority-Blocker
Oct 19, 2015
Project Member #7 david.pu...@sonymobile.com
(No comment was entered for this change.)
Labels: Blocking-2.12
Nov 6, 2015
Project Member #9 huga...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.12
Dec 21, 2015
Project Member #10 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting