My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3386: Issue tracking systems (all) don't work when plugin.<name>.branch is specified
1 person starred this issue and may be notified of changes. Back to list
Status:  Submitted
Owner:  ----
Closed:  May 2015


Sign in to add a comment
 
Reported by eng...@gmail.com, May 21, 2015
Hi.
All Issue tracking systems don't work when plugin.<its-name>.branch is specified. Problem is in its-base/src/main/java/com/googlesource/gerrit/plugins/hooks/its/ItsConfig.java

When affected branch for its is specified e.g. 

plugin.its-bugzilla.branch = refs/heads/*

then it is tested in "public boolean isEnabled(ChangeEvent event)" function and argument passed to next isEnabled is "e.change.branch". But this is a short name of the branch 

in gerrit/gerrit-server/src/main/java/com/google/gerrit/server/events/EventFactory.java

a.branch = change.getDest().getShortName();

---
e.change.branch contains for "refs/heads/master" only "master" and for "refs/meta/config" it contains full branch name "refs/meta/config"


I wonder if it ever worked. Support was done by https://gerrit-review.googlesource.com/#/c/53659/

Issue #3380 should be merged to this one.
May 21, 2015
#1 eng...@gmail.com
I see the resolution already in master branch https://gerrit-review.googlesource.com/#/c/67850/.

Please close.
May 22, 2015
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Jul 17, 2015
#3 l.brueni...@googlemail.com
Could you please fix this also in 2.11 
Sign in to add a comment

Powered by Google Project Hosting