My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3383: Submit Button is very confusing
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2015


Sign in to add a comment
 
Reported by Dustin.D...@gmail.com, May 20, 2015
When performing a peer review. A comrade of mine had recently typed submit after adding some notes. He unknowingly then pushed to code to the remote (or as we call it... Brahma) causing a huge fuss. Could you please change this to something like "Push to Remote", "Push" or "Approve and Push". 

Thank you
May 20, 2015
Project Member #1 edwin.ke...@gmail.com
I think the names that you propose are not suitable. When you click on submit there is no interaction with a remote repository and also no git push operation is performed. What happens on submit depends on the submit type of the project, it may be a merge, rebase or cherry-pick inside of the repository on Gerrit. Still if you don't like the label, you can reconfigure it [1] and also change the tooltip [2].

[1] https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#change.submitLabel
[2] https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#change.submitTooltip
Status: Released
Sign in to add a comment

Powered by Google Project Hosting