My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3374: Documentation for "change-merged" hook is missing the "--newrev=" argument
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2015


Sign in to add a comment
 
Reported by aaronwells, May 17, 2015
I recently upgraded from Gerrit 2.6 to Gerrit 2.11. I noticed that my "change-merged" hook script is now receiving a "--newrev=" argument from Gerrit, but this argument isn't included in the list of expected arguments in the documentation: https://gerrit-documentation.storage.googleapis.com/Documentation/2.11/config-hooks.html#_change_merged

Affected Version: Gerrit 2.11

What steps will reproduce the problem?
1. Place a Gerrit hook script in /hook/change-merged
2. Look at the arguments that it receives from Gerrit when you merge a patch

What is the expected output? What do you see instead?

The expected argument list should match what's in the documentation, "change-merged --change <change id> --change-url <change url> --change-owner <change owner> --project <project name> --branch <branch> --topic <topic> --submitter <submitter> --commit <sha1>"

What you actually receive is the same as above, but also with a "--newrev <new rev>" argument.

Please provide any additional information below.

I assume this is a new feature, not a bug. So probably just the docs need to be updated.
May 18, 2015
Project Member #1 edwin.ke...@gmail.com
Already fixed by:
  https://gerrit-review.googlesource.com/67471
Status: Submitted
Labels: FixedIn-2.11.1
Jun 21, 2015
Project Member #2 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting