My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3361: JGit "pack is corrupt, removing it from pack list"
12 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Oct 8
Cc:  sasa.ziv...@sap.com


Sign in to add a comment
 
Reported by everett....@gmail.com, May 11, 2015
Affected Version: 2.10.2-23-g039a170

What steps will reproduce the problem?

Go to https://review.openstack.org/#/c/181918/

What is the expected output? 

A review

What do you see instead?

Nothing

Please provide any additional information below.

Stack trace: http://fpaste.org/220778/13691291/
May 15, 2015
Project Member #1 David.Os...@gmail.com
It was reported to dev ML: [1], that the attempt to read pack file wasn't successful:

[2015-05-11 16:30:13,687] ERROR org.eclipse.jgit.internal.storage.file.ObjectDirectory : Pack file /home/gerrit2/review_site/git/openstack/nova.git/objects/pack/pack-93ad57004de887eb835b2bd4df2d7c3f6a5c394b.pack is corrupt, removing it from pack list
org.eclipse.jgit.errors.CorruptObjectException: Object at 87,706,216 in /home/gerrit2/review_site/git/openstack/nova.git/objects/pack/pack-93ad57004de887eb835b2bd4df2d7c3f6a5c394b.pack has bad zlib stream
        at org.eclipse.jgit.internal.storage.file.PackFile.load(PackFile.java:840)
        at org.eclipse.jgit.internal.storage.file.PackFile.get(PackFile.java:259)
        at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedObject(ObjectDirectory.java:417)
        at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openPackedFromSelfOrAlternate(ObjectDirectory.java:386)
        at org.eclipse.jgit.internal.storage.file.ObjectDirectory.openObject(ObjectDirectory.java:378)
        at org.eclipse.jgit.internal.storage.file.WindowCursor.open(WindowCursor.java:145)
        at org.eclipse.jgit.diff.ContentSource$ObjectReaderSource.open(ContentSource.java:140)
        at org.eclipse.jgit.diff.ContentSource$Pair.open(ContentSource.java:276)
        at org.eclipse.jgit.diff.DiffFormatter.open(DiffFormatter.java:1033)
        at org.eclipse.jgit.diff.DiffFormatter.createFormatResult(DiffFormatter.java:963)
        at org.eclipse.jgit.diff.DiffFormatter.toFileHeader(DiffFormatter.java:928)
        at com.google.gerrit.server.patch.PatchListLoader$2.call(PatchListLoader.java:203)
        at com.google.gerrit.server.patch.PatchListLoader$2.call(PatchListLoader.java:200)
        at java.util.concurrent.FutureTask.run(FutureTask.java:262)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
        at java.lang.Thread.run(Thread.java:745)
Caused by: java.util.zip.DataFormatException
        at org.eclipse.jgit.internal.storage.file.WindowCursor.inflate(WindowCursor.java:323)
        at org.eclipse.jgit.internal.storage.file.PackFile.decompress(PackFile.java:340)
        at org.eclipse.jgit.internal.storage.file.PackFile.load(PackFile.java:813)
        ... 16 more

[1] https://groups.google.com/forum/#!topic/repo-discuss/CYYoHfDxCfA
Status: AwaitingInformation
May 15, 2015
Project Member #2 David.Os...@gmail.com
Were you able to reproduce the problem?

Summary: JGit "pack is corrupt, removing it from pack list" (was: Review does not display)
May 15, 2015
#3 everett....@gmail.com
Looks like OpenStack reverted to 2.8.4-19-g4548330 as of writing this.

Can't reproduce at the moment.
May 15, 2015
#4 jt...@evernote.com
We upgraded to Gerrit 2.10 this morning and have seen this issue twice, affecting three different repositories. The only work-around we've found so far is restarting our Gerrit instance.
May 17, 2015
Project Member #5 David.Os...@gmail.com
What 2.10 version are you using? In case of OpenStack, it was 2.10.2 with JGit 3.7 that is known to suffer from this JGit regression: [1]. Only 2.10.4 is free from this issue, with bundled JGit 4.0.0.201505050340-m2.

Can you provide more details on how to reproduce this issue, so that we can investigate it in development environment?

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=465509


May 18, 2015
#6 jt...@evernote.com
Sorry - I misspoke; we upgraded to Gerrit 2.11. I don't have any more details yet but will be working this week to figure out reproduction steps.
May 18, 2015
Project Member #7 David.Os...@gmail.com
Gerrit 2.11 has the same JGit version as 2.10 (untill 2.10.4) and thus affected by JGit regression mentioned in my previous comment. stable-2.11 branch was fixed and JGit was upgraded to 4.0.0.201505050340-m2.jar, but 2.11.1 with this fix wasn't released yet. Pick the latest buid from Gerrit CI and try the latest 2.11 version available: [1]. Verify the JGit version:

  $ jar -tf release.war | grep org.eclipse.jgit-
  WEB-INF/lib/org.eclipse.jgit-4.0.0.201505050340-m2.jar

[1] https://ci.gerritforge.com/view/Gerrit/job/Gerrit-stable-2.11/lastSuccessfulBuild/artifact/buck-out/gen/release.war

Jul 20, 2015
Project Member #8 zaro0508
I believe this is the same issue as reported in bug https://code.google.com/p/gerrit/issues/detail?id=3424

The error from that issue was also a "pack is corrupt, removing it from pack list".

Jul 20, 2015
Project Member #9 bassem.rabil
This has been fixed in Gerrit 2.11.2 as described in the duplicate issue [1]

[1] https://code.google.com/p/gerrit/issues/detail?id=3424
Oct 8, 2015
Project Member #10 David.Os...@gmail.com
https://gerrit-review.googlesource.com/71341
Status: ChangeUnderReview
Oct 8, 2015
Project Member #12 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.11.4
Oct 9, 2015
Project Member #13 David.Os...@gmail.com
 Issue 3424  has been merged into this issue.
Cc: sasa.ziv...@sap.com
Oct 9, 2015
Project Member #14 ekem...@google.com
(No comment was entered for this change.)
Labels: -FixedIn-2.11.4 FixedIn-2.10.7
Oct 12, 2015
Project Member #15 ziv...@gmail.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting