| Issue 3345: | Preserve line-endings in inline editing | |
| 17 people starred this issue and may be notified of changes. | Back to list |
***************************************************************** ***** ***** ***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!! ***** ***** ***** ***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD, ***** ***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.***** ***** ***** ***** THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS ***** ***** ***** ***************************************************************** Affected Version: 2.11 What steps will reproduce the problem? 1. Edit one line of a file which has DOS style line-endings (\r\n) in the new inline-editor 2. publish the new change 3. All line-endings have been replaced by \n What is the expected output? What do you see instead? I would expect the line-endings of all lines to be preserved as is, that should be \r\n instead of \n. If new lines are added during inline editing, I would expect to set line-endings in the same style as preceding line-endings. Please provide any additional information below.
Apr 30, 2015
#1
icee...@googlemail.com
May 4, 2015
Yep, you're right. It should respect the autocrlf settings. In case autocrlf is set to false, however, the inline editor should not replace the line endings of the whole file.
Aug 18, 2015
we had the same issue on a rather large repository too. for us it is a no-go to change line endings, we'd need a fix for that :) |
|
| ► Sign in to add a comment |