| Issue 3304: | datacell class missing title element when "Display in Review Category" set to name, email or username | |
| 2 people starred this issue and may be notified of changes. | Back to list |
We have a use case where we want to replace the gerrit vote icons with custom icons (more info in issue 2685). We've done this with a javascript that updates the web page after it has been rendered. This script work when user preferences "Display in Review" is set to 'None' or 'Abbreviated Name', it does not work when "Display in Review" is set to 'name', 'email', or 'username'. The problem is that the latter options render the datacell class without without a title. We need the title because we only want to set a custom icon on a specific vote. The title should be there for every option. Affected Version: 2.10.2 What steps will reproduce the problem? 1. Set Preferences->Display in Review Category->None 2. Goto any search results page and bring up the Chrome debugger Look at the elements tab and look for the div for the datacell containing the Approval score. It contain a title, like so: <td class="dataCell cAPPROVAL singleLine" title="Workflow by Khai Do"><img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA8AAAAPCAYAAAA71pVKAAAAo0lEQVR42mNgGPrg8+7d/191dPwnWePPu3f/XxEUBGNk8bczZ/6/yMAAFgepwWkrSBEIw2x/Vl4OFwPhB6GhuF11XUkJrvBxWhqcDbIV5AK8Tv925gxYIbJtt4yN//959464cAA5GVkzQRux+RsZ33Vx+f9h1ar/RNkIcjrICyBNyIaAwgTDCyB/IStCjmuQs0GGgTSCDMSwFWQazBayEgndAQAqW6dvdnJ0RwAAAABJRU5ErkJggg==" width="15" height="15" class="gwt-Image"></td> 3. Set Preferences->Display in Review Category->Email 4. Goto any search results page and bring up the Chrome debugger I would expect the datacell class to be consistent and contain a title element but this is what I see (no title): <td class="dataCell cAPPROVAL singleLine"><div><img src="data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA8AAAAPCAYAAAA71pVKAAAAo0lEQVR42mNgGPrg8+7d/191dPwnWePPu3f/XxEUBGNk8bczZ/6/yMAAFgepwWkrSBEIw2x/Vl4OFwPhB6GhuF11XUkJrvBxWhqcDbIV5AK8Tv925gxYIbJtt4yN//959464cAA5GVkzQRux+RsZ33Vx+f9h1ar/RNkIcjrICyBNyIaAwgTDCyB/IStCjmuQs0GGgTSCDMSwFWQazBayEgndAQAqW6dvdnJ0RwAAAABJRU5ErkJggg==" width="15" height="15" class="gwt-Image"><span class="gwt-InlineLabel">zaro0508@gmail.com</span></div></td>
Apr 15, 2015
Project Member
#1
david.pu...@sonymobile.com
Apr 15, 2015
never mind; after looking into the code it's obvious.
Apr 15, 2015
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.11
Apr 16, 2015
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |