My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 33: Quote the source line when displaying/emailing line level comments
  Back to list
Status:  Released
Owner:  code-rev...@gtempaccount.com
Closed:  Oct 2012


Sign in to add a comment
 
Reported by code-rev...@gtempaccount.com, Sep 24, 2009
Reported by Shawn Pearce <sop@google.com> on Thu Jan 22 09:46:46 PST 2009
Source: JIRA GERRIT-33
Affected Version: 2.0

Gerrit1 (and Reitveld) included the quoted line from the source file when
sending out line level comments by email.  For example, it might show the
following if the comment was placed on a line declaring "int foo = 4":

  Line 4:         int foo = 4;
  No foo.  Textbooks ain't no good for learn'n.

This should be a matter of pulling up the patch to get the blob, opening it,
converting it to a line map with RawParseUtils.lineMap, then extracting the
relevant line(s).  SideBySidePatchDetailAction has about half of the code
needed for this.
Sep 24, 2009
#1 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Thu Jan 22 09:47:14 PST 2009
Labels: -Priority-Major Priority-Minor
Sep 24, 2009
#2 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Fri Mar 20 12:50:29 PDT 2009
Sep 24, 2009
#3 code-rev...@gtempaccount.com
Comment by Shawn Pearce <sop@google.com> on Fri Mar 20 13:42:45 PDT 2009

In email, fixed by https://review.source.android.com/9318

In the publish comments screen, this is rather hard.  The screen loads from
ChangeDetailServiceImpl, which doesn't have access to the server side code
like Repository or RawParseUtils in JGit, which are needed for the new
PatchFile class I introduced to make this work.  So I'm punting and saying
"good enough for now" and closing this issue.
Sep 24, 2009
#4 code-rev...@gtempaccount.com
Update by Shawn Pearce <sop@google.com> on Fri Mar 20 13:42:45 PDT 2009

Fixed in version 2.0.8.
Status: Fixed
Sep 25, 2009
#5 code-rev...@gtempaccount.com
(No comment was entered for this change.)
Labels: FixedIn-2.0.8
Oct 25, 2012
#6 sop@google.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting