My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3294: Removing a file in Edit mode should revert its changes rather than deleting it
2 people starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  May 2015
Cc:  David.Os...@gmail.com


Sign in to add a comment
 
Reported by org...@gmail.com, Apr 13, 2015
Affected Version: 2.11

What steps will reproduce the problem?
1. Click Edit
2. Click the X icon next to some file

What is the expected output? What do you see instead?
The file should not appear in the patch set (changes reverted).
Instead, it is deleted.

Apr 14, 2015
Project Member #1 david.pu...@sonymobile.com
(No comment was entered for this change.)
Cc: David.Os...@gmail.com
Apr 15, 2015
Project Member #2 David.Os...@gmail.com
Nope. Deleting file operation does what it should: delete the file.

Reverting file operation is implemented in two steps:

1. Delete the file
2. Restore the file

It should be probably better documented, though.

Status: AwaitingInformation
Apr 15, 2015
#3 org...@gmail.com
Why should a file be deleted by a single click operation? I find it weird, since it is rarely done.
Apr 15, 2015
Project Member #4 David.Os...@gmail.com
https://gerrit-review.googlesource.com/67135
Status: ChangeUnderReview
May 3, 2015
Project Member #5 David.Os...@gmail.com
(No comment was entered for this change.)
Status: Accepted
May 5, 2015
Project Member #6 edwin.ke...@gmail.com
https://gerrit-review.googlesource.com/67612
Status: ChangeUnderReview
May 21, 2015
Project Member #7 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.12
Dec 21, 2015
Project Member #8 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting