My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3292: Problems with copyAllScoresOnTrivialRebase=true not copying scores
2 people starred this issue and may be notified of changes. Back to list
Status:  WontFix
Owner:  ----
Closed:  May 2015


Sign in to add a comment
 
Reported by oyvindha...@gmail.com, Apr 13, 2015
Affected Version: 2.10

What steps will reproduce the problem?

1. patchset 3 is pushed for review. It is put into the build queue on Jenkins as there is no build capacity available.
2. a trivial rebase of patchset 4 is pushed for review. The votes are copied, but as patchset 3 is not build yet, there is no Verified+1 or Verified-1 to copy.
3. patchset 3 is built, but the Verified+1 vote is not copied to patchset 4.
4. we use the gerrit-trigger-plugin to skip builds on trivial rebase, so there's no build of patchset 4.

What is the expected output?

Patchset 4 receiving Verified+1 or Verified-1 when Jenkins completes builds of patchset 3.

What do you see instead?

Patchset 4 never receives a Verified+1

Apr 13, 2015
Project Member #1 david.pu...@sonymobile.com
I think this is working as designed from Gerrit point of view.  Copy all scores only copies scores that already exist when the new patch set is created.

In this case Jenkins is sending the review on patch set 3 AFTER patch set 4 has been created.  This review will be ignored by Gerrit because patch set 4 already exists and reviews are only accepted on the latest patch set.


Status: AwaitingInformation
May 5, 2015
Project Member #2 edwin.ke...@gmail.com
Works as designed.
Status: WontFix
Sign in to add a comment

Powered by Google Project Hosting