My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3283: Abandoned changes are linked to gitweb in related changes tab
1 person starred this issue and may be notified of changes. Back to list
Status:  Duplicate
Merged:  issue 2894
Owner:  ----
Closed:  Apr 2015
Cc:  edwin.ke...@gmail.com


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Apr 8, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: master

What steps will reproduce the problem?
1. Abandon a whole series of changes
2. From the "abandoned" list, open one of them
3. Try to navigate to a previous change in the series

What is the expected output? What do you see instead?

Expect that the link in the related list takes me to the change screen for the abandoned change, but it takes me to gitweb (gitiles on gerrit-review).

See [1] for example

[1] https://gerrit-review.googlesource.com/#/c/47206/


Please provide any additional information below.

Looking at the code it seems that this was by design because it only fetches open changes initially, then any merged or abandoned ones are only added by commit afterwards.

Apr 8, 2015
Project Member #1 edwin.ke...@gmail.com
I thought I fixed this by [1]... :-(

[1] https://gerrit-review.googlesource.com/62236
Apr 8, 2015
Project Member #2 david.pu...@sonymobile.com
Looking at the output of the /related endpoint when the changes are abandoned, it seems like the difference is that the abandoned ones don't have a change_id field.

Maybe worth adding a test for it?  I see there wasn't one added with that change ;)

Apr 8, 2015
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Duplicate
Mergedinto: 2894
Sign in to add a comment

Powered by Google Project Hosting