My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3254: ChangeScreen: Pressing 'a' to reply to the change causes a JS error
1 person starred this issue and may be notified of changes. Back to list
Status:  CannotReproduce
Owner:  ----
Closed:  Apr 2015


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Mar 19, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.11-rc1 and latest (2.11-rc1-123-geb7d88c)

What steps will reproduce the problem?
1. Enter side-by-side diff
2. Press 'a'
3.

What is the expected output? What do you see instead?

Expected: go back to the change screen and open the reply box

Actual: back to the change screen, but the reply box does not open.  JS error (pasted below) is shown in the dev console.


Please provide any additional information below.

SEVERE: (TypeError) : Cannot read property 'onReply_2' of undefinedClass$S124: (TypeError) : Cannot read property 'onReply_2' of undefined
	at Unknown.onReply(gerrit_ui-0.js)
	at Unknown.onShowView_6(gerrit_ui-0.js)
	at Unknown.onShowView_0(gerrit_ui-0.js)
	at Unknown.onShowView_1(gerrit_ui-0.js)
	at Unknown.swap(gerrit_ui-0.js)
	at Unknown.display_3(gerrit_ui-0.js)
	at Unknown.onSuccess_28(gerrit_ui-0.js)
	at Unknown.applySuccess(gerrit_ui-0.js)
	at Unknown.apply_2(gerrit_ui-0.js)
	at Unknown.success(gerrit_ui-0.js)
	at Unknown.onSuccess_313(gerrit_ui-0.js)
	at Unknown.onSuccess_318(gerrit_ui-0.js)
	at Unknown.execute_21(gerrit_ui-0.js)
	at Unknown.onResponseReceived_0(gerrit_ui-0.js)
	at Unknown.fireOnResponseReceived(gerrit_ui-0.js)
	at Unknown.onReadyStateChange(gerrit_ui-0.js)
	at Unknown.<anonymous>(gerrit_ui-0.js)
	at Unknown.apply_8(gerrit_ui-0.js)
	at Unknown.entry0(gerrit_ui-0.js)
	at Unknown.<anonymous>(gerrit_ui-0.js)
Mar 19, 2015
Project Member #1 david.pu...@sonymobile.com
I initially suspected that something in the key_navigation series of changes [1] could be the cause of this, but after reverting those changes the problem still occurs.

[1] https://gerrit-review.googlesource.com/#/q/topic:key_navigation

Mar 19, 2015
Project Member #2 david.pu...@sonymobile.com
(No comment was entered for this change.)
Labels: Blocking-2.11
Mar 23, 2015
Project Member #3 sbel...@google.com
Please also look at [1], which seems to be a firefox issue.
I tried reproducing this one and can confirm it in both firefox and chrome.

[1] https://gerrit-review.googlesource.com/#/c/66190/
Apr 5, 2015
Project Member #4 david.pu...@sonymobile.com
Unable to reproduce this on latest head of stable-2.11 (v2.11-rc1-54-g75b5190)
Status: CannotReproduce
Labels: -Blocking-2.11
Sign in to add a comment

Powered by Google Project Hosting