My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3220: Stream events do not include the label (vote) info
1 person starred this issue and may be notified of changes. Back to list
Status:  ChangeUnderReview
Owner:  zaro0508


Sign in to add a comment
 
Project Member Reported by zaro0508, Feb 27, 2015
We use stream events heavily and want info on the votes even if it did not change.  One of our use cases is to automate tasks depending on comments and label info on any event.  An event that encompass the entire data of the event (include the labels) would help.

Affected Version: master

What steps will reproduce the problem?
1. view the Gerrit stream events
2. create a change
3. vote on that change with a Code-Review +1/-1 

Note - the event contains the label info:
"approvals":[{"type":"Code-Review","description":"Code-Review","value":"1"}],"comment":"Patch Set 2: Code-Review+1"}

4. now vote on that change again. This time add a comment but don't change any votes.
Note - the event does not contain the label infos, only the comment that was added.

What is the expected output? What do you see instead?
I would expect the event to contain the label info even if it didn't change. 


Feb 27, 2015
Project Member #1 zaro0508
change for this: https://gerrit-review.googlesource.com/#/c/65530
Status: ChangeUnderReview
Owner: zaro0508
May 18, 2015
Project Member #2 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.12
May 19, 2015
Project Member #3 edwin.ke...@gmail.com
The change was reverted:
  https://gerrit-review.googlesource.com/67973
Status: New
Labels: -FixedIn-2.12
May 21, 2015
#4 icee...@googlemail.com
The problem is, that there are different use cases where the current behaviour seems better. 

E.g. we have a custom label that triggers builds on jenkins (via gerrit-trigger-plugin) if it is set. So we do not want this to appear in the event if a unrelated comment is set on the change.
May 24, 2015
Project Member #5 zaro0508
@iceelch, Could you please help me understand your use case a little more?  When a comment is added to a change how can you tell if it is unrelated to that change?  The label appearing in the stream event only means that there has been some modification to a vote it does not mean that the associated comments are related to that change.  I think in your use case you still have the data to either trigger or ignore.  In my use case I need both the comment and label data to decide whether I want to trigger a build. 
Jun 1, 2015
Project Member #6 zaro0508
Sorry guys, could we please try again?  This change includes a fix for the tests: https://gerrit-review.googlesource.com/#/c/68242
Status: ChangeUnderReview
Sign in to add a comment

Powered by Google Project Hosting