My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3218: Side-By-Side: "Fix" button should not be offered for commit message lines within the header
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Feb 27, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.11-rc0

What steps will reproduce the problem?
1. On a change under review, open side-by-side on a commit message
2. Add a comment on the 'Author' line in the header, and publish it
3. Expand the saved comment

What is the expected output? What do you see instead?

On the expanded comment there are the buttons "Reply", "Done" and "Fix".

Clicking "Fix" opens the editor and places the focus at line 2 (or 3 if it's a merge) of the commit message.

Since the header lines are not editable in the inline editor, the "Fix" button should not be offered for lines that are within the header.

Please provide any additional information below.

Sign in to add a comment

Powered by Google Project Hosting