My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3217: Inline Edit: Jump to line with 'm' from side-by-side does not work properly for commit messages
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Mar 2015


Sign in to add a comment
 
Project Member Reported by david.pu...@sonymobile.com, Feb 27, 2015
*****************************************************************
*****                                                       *****
***** !!!! THIS BUG TRACKER IS FOR GERRIT CODE REVIEW !!!!  *****
*****                                                       *****
***** DO NOT SUBMIT BUGS FOR CHROME, ANDROID, CYANOGENMOD,  *****
***** INTERNAL ISSUES WITH YOUR COMPANY'S GERRIT SETUP, ETC.*****
*****                                                       *****
*****   THOSE ISSUES BELONG IN DIFFERENT ISSUE TRACKERS     *****
*****                                                       *****
*****************************************************************

Affected Version: 2.11-rc0

What steps will reproduce the problem?
1. In a change under review, open the commit message in side-by-side diff
2. Move the cursor onto the commit message's subject line
3. Press 'm' to open the inline editor

What is the expected output? What do you see instead?

Expected: the editor opens with focus on the selected line

Actual: focus is on a line further down


Please provide any additional information below.


When viewing the commit message in side-by-side, the header information (parent(s), author name, author timestamp, committer, and committer timestamp) are also displayed.  For a non-merge commit these take up lines 1-5 and then there is a blank line, so the commit message title is on line 7.

In the editor the header lines are not included, so the title is at line 1.  But focus is set on line 7.
Feb 27, 2015
Project Member #1 david.pu...@sonymobile.com
https://gerrit-review.googlesource.com/#/c/65496/
Status: ChangeUnderReview
Mar 2, 2015
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Labels: FixedIn-2.11
Mar 2, 2015
Project Member #3 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Apr 16, 2015
Project Member #4 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting