| Issue 3197: | Submodule subscription doesn't work on 2 changes. | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Affected Version: current master (v2.10-1647-g97d0735) What steps will reproduce the problem? 1. First setup a repo and a submodule which is subscribed to commit all its changes to the repo. Validate it works when committing a single change in the submodule. 2. Enable `change.submitWholeTopic` 3. create 2 changes in te submodule with the same topic. Review them, "submit the whole topic". What is the expected output? What do you see instead? I'd expect the submodule to trigger some kind of update of the superproject to show the advances in the submodule, whether it's two updates or a single update. Instead nothing happens to the superproject. Please provide any additional information below. `change.submitWholeTopic` is rather new, and integrating that together with other features of gerrit is challenging. The most convenient would be to have just a single update to the superproject containing the update of the submodule by 2 commits, also stating the topic and saying it's intentional to have merged 2 changes at the same time.
Feb 19, 2015
Project Member
#1
sbel...@google.com
Feb 19, 2015
This is spot on. Commenting out the offending line at com.google.gerrit.server.git.SubmoduleOp.updateSuperProjects(SubmoduleOp.java:230) makes gerrit work again with submodule updates commited in the same topic as super project updates.
Mar 5, 2015
Attaching a script to reliably reproduce this bug, when having a submodule `submodule` which is subscript to a super project and `submitWholeTopic` is enabled.
Mar 5, 2015
(No comment was entered for this change.)
Apr 29, 2015
Fixed in https://gerrit-review.googlesource.com/#/c/64951/
Apr 29, 2015
(No comment was entered for this change.)
Status:
Submitted
Labels: FixedIn-2.12
Dec 21, 2015
(No comment was entered for this change.)
Status:
Released
|
|
| ► Sign in to add a comment |