My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 3162: InlineEdit: Prevent editing of binary files
1 person starred this issue and may be notified of changes. Back to list
Status:  Released
Owner:  ----
Closed:  Feb 2015


Sign in to add a comment
 
Project Member Reported by David.Os...@gmail.com, Feb 5, 2015

Affected Version: master

What steps will reproduce the problem?
1. Add binary file to a change
2. Open unified diff
3. Switch to side by side diff
4. Click edit icon in header of side by side screen

What is the expected output?

Edit icon shoudn't be offered in this case

What do you see instead?

5. Codemirror is opened with binary content
Feb 12, 2015
Project Member #1 David.Os...@gmail.com
https://gerrit-review.googlesource.com/64583
Status: ChangeUnderReview
Feb 17, 2015
Project Member #2 edwin.ke...@gmail.com
(No comment was entered for this change.)
Status: Submitted
Labels: FixedIn-2.11
Apr 16, 2015
Project Member #3 david.pu...@sonymobile.com
(No comment was entered for this change.)
Status: Released
Sign in to add a comment

Powered by Google Project Hosting